Do not After=network.target the -display & audiodetector services #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtertiaer
changed the title
rtertiaer
force-pushed
the
no_after_network_systemd
branch
from
52b9f35 to
be36588
Compare
|
With un-bonded grounds, the behavior of the display did not change. With bonded grounds, this briefly starts with "None" for the interface stuff, but otherwise boots up normally & "just works". I think we're also guarded against any potential exceptions with systemd restarting the service over time. But all in all, I can't demonstrate that this PR changes behavior at all, which could be good or pointless in this context 😂 It still feels more correct to have these services not necessarily wait for the network to be available; they should not have any hard dependencies on the network. |
Lohrer
approved these changes
Dec 11, 2023
rtertiaer
force-pushed
the
no_after_network_systemd
branch
from
be36588 to
2ca1da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some network oddities where the network initialization does not start or fail quickly but hangs for a long time, the display and audiodetector services also hang. I've removed that "weak dependency". This potentially allows us to give better feedback during bootup.
This still needs to be tested, in particular because of the display service potentially having a true dependency on networking at the moment; thus, I've filed this as a draft for now.