Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] : Youtube Video Is not Showing #293

Closed
divyansh-prks opened this issue Feb 10, 2025 · 17 comments
Closed

[Bug] : Youtube Video Is not Showing #293

divyansh-prks opened this issue Feb 10, 2025 · 17 comments
Labels
component/ux Improvements or additions to UX or style kind/enhancement New feature or request

Comments

@divyansh-prks
Copy link
Contributor

divyansh-prks commented Feb 10, 2025

Describe the bug

Image
The youtube video that is mentioned here , i am not able to play video on the webpage itself .

Expected behavior

The video should be working properly

Actual behavior

No response

How to Reproduce?

  1. Go here https://microcks.io/events/
  2. Scroll down to video number 13

Microcks version or git rev

No response

Install method (docker-compose, helm chart, operator, docker-desktop extension,...)

No response

Additional information

No response

Copy link

👋 @divyansh-prks

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first issue here! Be sure to follow the issue template or please update it accordingly.

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@yada
Copy link
Member

yada commented Feb 10, 2025

Hi @divyansh-prks ,
Correct but this video is not hosted on the Microcks YouTube channel. This issue is due to settings on the channel and we can not fix it (we are not admin). You can not see the previous or watch directly but can always watch on YouTube. So not the best experience but have no choice (except if we download and host the video ourselves). Any suggestions on this issue?
Regards,
Yacine

@divyansh-prks
Copy link
Contributor Author

In that case , see we can't play that video anyhow because it is not enabled by the owner .
My suggestion would Be ->
There are total 19 videos that we are embedding on the event page https://microcks.io/events/ which is also slowing down the page load time as you can see here

Image

So the efficient solution will be Instead of embedding all videos at once, display thumbnails of all the videos and load the video only when clicked which not only solve the problem of listing videos but also help to render the webpage fast

What do you think @yada ?

@divyansh-prks
Copy link
Contributor Author

https://github.com/user-attachments/assets/f8f79313-b7bb-4eb6-be10-a0e1e6bea37e
and also some videos are behaving like this

@yada
Copy link
Member

yada commented Feb 10, 2025

https://github.com/user-attachments/assets/f8f79313-b7bb-4eb6-be10-a0e1e6bea37e and also some videos are behaving like this

Weird, I do not see this on my side using Brave, Chrome or Safari!

@yada
Copy link
Member

yada commented Feb 10, 2025

In that case , see we can't play that video anyhow because it is not enabled by the owner . My suggestion would Be -> There are total 19 videos that we are embedding on the event page https://microcks.io/events/ which is also slowing down the page load time as you can see here

Image

So the efficient solution will be Instead of embedding all videos at once, display thumbnails of all the videos and load the video only when clicked which not only solve the problem of listing videos but also help to render the webpage fast

What do you think @yada ?

Agree, this could be a good workaround and optimization 👍
Can you do a PR on this?

@divyansh-prks
Copy link
Contributor Author

yes sure

@divyansh-prks
Copy link
Contributor Author

/assign

@divyansh-prks
Copy link
Contributor Author

divyansh-prks commented Feb 10, 2025

Before After
Before After

So here is the final optimization of this event webpage .

I want to ask a doubt do i add any popup animation when user hover those videos or should i keep it same as like this @yada ?

Image

Screencast.from.2025-02-10.23-38-15.webm

@yada
Copy link
Member

yada commented Feb 10, 2025

@divyansh-prks, that looks nice and cool, thanks.
Regarding your point "any popup animation": what will it look like? Sorry, I'm sure to visualize what you're dealing with, but anyway, please suggest what you like and think will be better from a user experience point of view 🙌

@yada
Copy link
Member

yada commented Feb 10, 2025

Do not hesitate to push a PR and iterate on it when you are ready so I can check locally ;-)

@divyansh-prks
Copy link
Contributor Author

Hey @yada i am not able to commit changes , i am checking git status it is showing nothing to commit . I have already checked so many times and i am also on correct directory .

Image

This is my forked repo and i am trying to do changes in the public folder but no changes is happening there

Image

May i know have you used any bundler? because the production code is looking like this and this production file is in another repository
https://github.com/microcks/microcks.github.io/blob/52021018c10f2f5e50604a7bb29666d30f0ba984/events/index.html

@divyansh-prks
Copy link
Contributor Author

But still i have sent a PR on another repository as well you can check it here
microcks/microcks.github.io#21

@yada
Copy link
Member

yada commented Feb 11, 2025

Hi @divyansh-prks ,
microcks.github.io repo is for website publication only, you are in the proper repo to update content.

But your issue is due to the fact you are making changes in the wrong directory:
use
microcks.io/content/events/_index.md
and not
/microcks.io/public/events/index.*

public directory is auto-generated ;)

@divyansh-prks
Copy link
Contributor Author

oh sorry yada i was actually bit of confused . I have raised the pr if i have to do changes in this directory microcks.io/content/events/_index.md

you can check this pr ->
PR #307 Yt video showing

@yada
Copy link
Member

yada commented Feb 11, 2025

But still i have sent a PR on another repository as well you can check it here microcks/microcks.github.io#21

I'm rejecting the PR based on the explanation above ;)

@yada
Copy link
Member

yada commented Feb 12, 2025

Ref with #307

@yada yada closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ux Improvements or additions to UX or style kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants