-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] : Youtube Video Is not Showing #293
Comments
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first issue here! Be sure to follow the issue template or please update it accordingly. 📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌" Hope you have a great time there! 🌟 ~~~~~~~~~ 🌟 📢 If you like Microcks, please ⭐ star ⭐ our repo to support it! 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. |
Hi @divyansh-prks , |
In that case , see we can't play that video anyhow because it is not enabled by the owner . So the efficient solution will be Instead of embedding all videos at once, display thumbnails of all the videos and load the video only when clicked which not only solve the problem of listing videos but also help to render the webpage fast What do you think @yada ? |
https://github.com/user-attachments/assets/f8f79313-b7bb-4eb6-be10-a0e1e6bea37e |
Weird, I do not see this on my side using Brave, Chrome or Safari! |
Agree, this could be a good workaround and optimization 👍 |
yes sure |
/assign |
So here is the final optimization of this event webpage . I want to ask a doubt do i add any popup animation when user hover those videos or should i keep it same as like this @yada ? Screencast.from.2025-02-10.23-38-15.webm |
@divyansh-prks, that looks nice and cool, thanks. |
Do not hesitate to push a PR and iterate on it when you are ready so I can check locally ;-) |
Hey @yada i am not able to commit changes , i am checking git status it is showing nothing to commit . I have already checked so many times and i am also on correct directory . This is my forked repo and i am trying to do changes in the public folder but no changes is happening there May i know have you used any bundler? because the production code is looking like this and this production file is in another repository |
But still i have sent a PR on another repository as well you can check it here |
Hi @divyansh-prks , But your issue is due to the fact you are making changes in the wrong directory: public directory is auto-generated ;) |
oh sorry yada i was actually bit of confused . I have raised the pr if i have to do changes in this directory microcks.io/content/events/_index.md you can check this pr -> |
I'm rejecting the PR based on the explanation above ;) |
Ref with #307 |
Describe the bug
The youtube video that is mentioned here , i am not able to play video on the webpage itself .
Expected behavior
The video should be working properly
Actual behavior
No response
How to Reproduce?
Microcks version or git rev
No response
Install method (
docker-compose
,helm chart
,operator
,docker-desktop extension
,...)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: