All Yt Video thumbnail is Visible #307
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! 🌟 ~~~~~~~~~ 🌟 📢 If you like Microcks, please ⭐ star ⭐ our repo to support it! 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. |
Signed-off-by: divyansh <[email protected]>
divyansh-prks
force-pushed
the
divyansh
branch
from
ec15062 to
d9465be
Compare
Signed-off-by: divyansh <[email protected]>
divyansh-prks
force-pushed
the
divyansh
branch
from
7608880 to
0e36e7e
Compare
Please add some infos and do not forget the related issue number (important to track and follow) ;) |
Signed-off-by: divyansh <[email protected]>
|
@divyansh-prks "This branch has conflicts that must be resolved" as config/_default/hugo.toml has been changed in the meantime. Please update your PR accordingly, see: githubteacher/github-for-developers-sept-2015#648 |
|
yes i did changes in hugo.toml file because i wanted to solves all the checks by myself . I will make sure i will resolved it as soon as possible |
Thanks cause check fixed already with #302 |
|
BTW do not mix different changes in the same PR when it is linked to different issues. |
This fix is merged, so now you also need to remove content/documentation/guides/automation/cli.md from this PR |
I know these conflict issues are tricky. I'll merge this new PR, but for the next PR, please see the git command to keep the same PR and resolve conflicts, as this is a very common use case on GitHub projects and something to learn: many other projects will not accept to manage conflicts by closing and creating new PRs 😎 |
|
thank you for understanding yada . Yeah i was actually learning those commands right now XD |
Description
Screencast from 2025-02-12 01-52-25.webm
I have done changes in the directory microcks.io/content/events/_index.md , where instead of rendering all yt videos using iframe i have used anchored tag and link thumbnails of all the videos which when user clicks on those thumbnail will play youtube video.
It enhances the performance and also it shows all yt video are playable correctly .
resolves issue #293
Related issue(s)