Fixes 286: Missing INSTALLATION.md #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @yada @lbroudoux |
yada
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for this contrib.
1/ Please fix the DCO check, it is mandatory
2/ For the latest sentence (contributing), could you add a link to CONTRIBUTING.md where we have all infos, something like: .../... Check out our CONTRIBUTING guide for details. Happy coding! 🚀
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: Laurent Broudoux <[email protected]> Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: Vicky Besra <[email protected]> Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
Signed-off-by: krishi-agrawal <[email protected]>
krishi-agrawal
force-pushed
the
fixes-286
branch
from
ac83f74 to
5768599
Compare
|
i have created a new PR which passes all the checks. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #286
Created an INSTALLAION.md file to help contributors in setting up the repository locally.
Related issue(s)