JSON rules cleanup #559
Merged
JSON rules cleanup #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree [company="Anvil Secure"] |
|
@microsoft-github-policy-service agree company="Anvil Secure" |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Tests are succeeding locally, but also must run as a PR gate. Need to investigate why the pipeline isn't triggering here. @daalcant |
gfs
approved these changes
Aug 29, 2023
|
Updated the PR pipeline fork triggers, but that didn't help. Kicked off a manual run to (hopefully) get this unblocked. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON rules are not always consistent. There are rules with unused fields, rules with fields being encountered twice or just completely wrong fields that don't have any meaning in the context of ApplicationInspector. This is not a big issue let alone a issue at all for appinspect itself. However if one is parsing the JSON rules with a stricter JSON parser which has more validation enabled this becomes an issue.