Merge pull request #9527 from OEvgeny/fix/packages-readme

fix: package manager readme display in sidebar and modal
microsoft · Mar 28, 2023 · 8628464 · 8628464
2 parents 6b6b0cd + 3ae40d1
commit 8628464
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/extensions/packageManager/src/pages/Library.tsx b/extensions/packageManager/src/pages/Library.tsx
@@ -211,7 +211,7 @@ const Library: React.FC = () => {
   };
 
   const getReadmeAPI = (packageName: string) => {
-    return httpClient.get(`${API_ROOT}/readme/${packageName}`);
+    return httpClient.get(`${API_ROOT}/readme/${encodeURIComponent(packageName)}`);
   };
 
   const uninstallComponentAPI = (projectId: string, packageName: string) => {
@@ -446,15 +446,15 @@ const Library: React.FC = () => {
         setWorking('');
         updateInstalledComponents(results.data.components);
 
+        await reloadProject();
+
         // find newly installed item
         // and pop up the readme if one exists.
         const newItem = results.data.components.find((i) => i.name === packageName);
         if (newItem?.readme) {
           setSelectedItem(newItem);
           setReadmeHidden(false);
         }
-
-        await reloadProject();
       }
     } catch (err) {
       telemetryClient.track('PackageInstallFailed', { package: packageName, version: version, isUpdate: isUpdating });
@@ -631,7 +631,7 @@ const Library: React.FC = () => {
       {selectedItem && (
         <DisplayMarkdownDialog
           content={selectedItem?.readme}
-          hidden={readmeHidden}
+          hidden={readmeHidden || !selectedItem?.readme}
           title={'Project Readme'}
           onDismiss={() => {
             setReadmeHidden(true);