refactor(tinylicious-client): Clean up package exports #21370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
public api change
Josmithr
commented
Jun 11, 2024
| export { ITelemetryBaseLogger } | ||
|
|
||
| export { TinyliciousClient } | ||
| export default TinyliciousClient; |
There was a problem hiding this comment.
The exports of TinyliciousClient should not have appeared in any of these reports, since it is tagged as @internal.
I've filed a bug with API-Extractor about this issue: microsoft/rushstack#4775
alexvy86
approved these changes
Jun 11, 2024
Git blame shows it being internal since our initial tagging pass. So, it has never been explicitly marked as public. I think we're probably okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package's primary export
TinyliciousClient(as well as its related types) have all been made internal. Unfortunately, a bug in API-Extractor related to how it resolvesexport defaultstatements was causing theTinyliciousClienttype to appear in API reports when it shouldn't have.Additionally, this package was re-exporting a couple of telemetry types to make use by external users more convenient (so they wouldn't have to import the
core-interfacespackage). But since this entire package is effectively internal-only now, these don't serve much purpose. I have removed them.