Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for passing client display name used when attributing changes to the current client in the collab session #23422

Conversation

AndreiZe
Copy link
Contributor

@AndreiZe AndreiZe commented Jan 2, 2025

Allow for passing client display name used when attributing changes to the current client in the collab session

How contribute to this repo.

Guidelines for Pull Requests.

The sections included below are suggestions for what you may want to include.
Feel free to remove or alter parts of this template that do not offer value for your specific change.

Description

This change introduces support for overriding the client display name used when attributing changes to the current client in the collab session. This can be used in scenarios where the client display name should be different from the default client display name, for instance, when client is running in app-only context.

This is achieved by adding a new optional property displayName to the ICollabSessionOptions interface. This interface is passed inside HostStoragePolicy which is specified when constructing document service factory. If displayName is specified, then it is used when establishing collab session and passed in the body of /joinSession request to Push service.

Reviewer Guidance

The review process is outlined on this wiki page.

…o the current client in the collab session
@Copilot Copilot bot review requested due to automatic review settings January 2, 2025 19:20
@AndreiZe AndreiZe requested a review from a team as a code owner January 2, 2025 19:20
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Jan 2, 2025
@AndreiZe AndreiZe requested a review from jatgarg January 2, 2025 19:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@AndreiZe AndreiZe merged commit ddce270 into microsoft:main Jan 8, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants