Allow for passing client display name used when attributing changes to the current client in the collab session #23422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for passing client display name used when attributing changes to the current client in the collab session
How contribute to this repo.
Guidelines for Pull Requests.
The sections included below are suggestions for what you may want to include.
Feel free to remove or alter parts of this template that do not offer value for your specific change.
Description
This change introduces support for overriding the client display name used when attributing changes to the current client in the collab session. This can be used in scenarios where the client display name should be different from the default client display name, for instance, when client is running in app-only context.
This is achieved by adding a new optional property
displayName
to theICollabSessionOptions
interface. This interface is passed insideHostStoragePolicy
which is specified when constructing document service factory. IfdisplayName
is specified, then it is used when establishing collab session and passed in the body of /joinSession request to Push service.Reviewer Guidance
The review process is outlined on this wiki page.