WIP: Introduce TrialRunner Abstraction #720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit test for bench (not tested)
…e bulk registration (check for is_warm_up)
bpkroth
commented
Jan 7, 2025
| assert { | ||
| trial_runner.environment.const_args["trial_runner_id"] | ||
| for trial_runner in launcher.trial_runners | ||
| } == set(range(0, len(launcher.trial_runners))) |
There was a problem hiding this comment.
FIXME: Some places I think we use 0 indexing and others 1 indexing. We should be consistent about that.
bpkroth
commented
Jan 7, 2025
| return config | ||
|
|
||
| # NOTE: This may no longer be necessary with the new schema. | ||
| def add_new_config_data( |
There was a problem hiding this comment.
These were refactored originally to avoid changing the schema. We don't need that anymore, but it still might be handy to keep around.
@motus, thoughts on reverting vs. just leaving this part of it? It also affects the _save_params code movement.
bpkroth
commented
Jan 7, 2025
| @@ -446,6 +455,25 @@ def tunables(self) -> TunableGroups: | |||
| """ | |||
| return self._tunables | |||
|
|
|||
| @abstractmethod | |||
| def assign_trial_runner(self, trial_runner_id: int) -> int: | |||
There was a problem hiding this comment.
Move this up to be near the property?
bpkroth
commented
Jan 7, 2025
| @@ -129,7 +129,7 @@ | |||
| >>> # Access ExperimentData by experiment id. | |||
| >>> experiment_data = storage.experiments["my_experiment_id"] | |||
| >>> experiment_data.trials | |||
| {1: Trial :: my_experiment_id:1 cid:1 SUCCEEDED} | |||
| {1: Trial :: my_experiment_id:1 cid:1 rid:None SUCCEEDED} | |||
There was a problem hiding this comment.
No runner assigned here. May want to note that in the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step in adding support for parallel trial execution #380.
Here we separate out the running of an individual trial to a single class - TrialRunner.
Multiple TrialRunners are instantiated at CLI invocation with the
--num-trial-runnersargument.Each TrialRunner associated with a single copy of the root Environment, and made unique by means of a unique
trial_runner_idvalue that's included in that Environment's global_config.TODO:
In future PRs we will add: