-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use token-based authentication instead of the access key in the AzureFileShareService #779
Conversation
Part of why we went with the Use of |
As long as we're removing account storage key, does removing fileshare also make sense? We could use blobs instead I guess. Maybe less nice though and too many changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Only feedback was to move the SupportsAuth
check to __init__
so we can check for proper configs at startup time rather than at file transfer need time which might be after some experiment trial has already run.
35e77b4
to
827492f
Compare
…vide a proper implementation later
Make
AzureFileShareService
class use token-based credential instead of the access key. This PR is part of #777NOTE:
_share_client
to avoid issues with JSON schema validation tests.azcopy
on the remote VMs instead of mounting the file share using the access key"storageAccountKey"
from configurations and tests and document the new mechanism