Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export of Firewall policy settings #5518

Merged

Conversation

FabienTschanz
Copy link
Contributor

@FabienTschanz FabienTschanz commented Dec 5, 2024

Pull Request (PR) description

This PR fixes an issue of export of IntuneFirewallPolicyWindows10. Settings like LogFilePath could be exported without their prefix for DomainProfile if it was only specified one time in the policy.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@FabienTschanz FabienTschanz marked this pull request as ready for review December 5, 2024 14:20
@FabienTschanz FabienTschanz force-pushed the fix/firewall-policy-export branch from 1f6fe62 to c1cd37d Compare December 5, 2024 14:57
@NikCharlebois NikCharlebois merged commit fbfbf20 into microsoft:Dev Dec 5, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/firewall-policy-export branch December 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants