Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate policy creation bug & dynamic group compliance #5627

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

AlfredSchreuder
Copy link
Contributor

Pull Request (PR) description

  • Fix duplicate policy creation bug, when existing policy was found in tenant, still a new policy was created.
  • Fix dynamic group compliance, when dynamic group was found, returned incompliant due to empty parameters Members & GroupAsMembers. Edited so that those params are only added to the comparison when it is a static group.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@AlfredSchreuder
Copy link
Contributor Author

@FabienTschanz New PR according to suggestions: #5536 (comment)

@FabienTschanz
Copy link
Contributor

@AlfredSchreuder Awesome, I like that! Looks good to me, thank you very much for your work.

@NikCharlebois NikCharlebois merged commit 69f160d into microsoft:Dev Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants