-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inlay hints #7898
Support inlay hints #7898
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
These look great! Just a couple of random questions:
Thank you! |
@AdamYoblick Didn't even know the hotkeys exist. How are they supposed to work? Is it like when I hit the letter on the keyboard it jumps to that option? Sure I can have the UI board review the changes, do you know how to reach out to them? |
Scroll down to |
|
|
Done addressing feedback from UXBoard review:) |
fixes #7888
Added these 2 options with tooltips that allow users to enable inlay hints in PTVS.
![image](https://private-user-images.githubusercontent.com/100439259/329385117-a0f5b8fe-2859-4849-ad8e-86e67aff8b6f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTI2ODQsIm5iZiI6MTczOTY5MjM4NCwicGF0aCI6Ii8xMDA0MzkyNTkvMzI5Mzg1MTE3LWEwZjViOGZlLTI4NTktNDg0OS1hZDhlLTg2ZTY3YWZmOGI2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNzUzMDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YjdkZmNlOGYzNTQ5NTQ0NjlmYjQzNDliNWM2NmRmNjg5YTY2NjBlYjQwOGNmM2ZhYjkxZjk2ZWY2YTRlODVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.1CG0UIm2EwVNpauR042RRzHUrilt_8_bLlanY3vE2gI)
Tooltips:
![image](https://private-user-images.githubusercontent.com/100439259/329385167-88c1bf3c-7439-4fe2-a6c6-421578f3f294.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTI2ODQsIm5iZiI6MTczOTY5MjM4NCwicGF0aCI6Ii8xMDA0MzkyNTkvMzI5Mzg1MTY3LTg4YzFiZjNjLTc0MzktNGZlMi1hNmM2LTQyMTU3OGYzZjI5NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNzUzMDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00N2NjZmExNTliZjdiMzQ5MGNlMDE1MTk5YzA2YWNiYzUyODFiNzZjYjM3YjQxOTQ1MTI2YTRlYTQ1NDY5MTA4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-zxrNMv0EibNi5TQkvpgm-OY8SLflVODGBeZkPjtZW8)
With inlay hints:
![image](https://private-user-images.githubusercontent.com/100439259/329385224-77f75aaf-018a-4406-a38a-29755eb93eb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTI2ODQsIm5iZiI6MTczOTY5MjM4NCwicGF0aCI6Ii8xMDA0MzkyNTkvMzI5Mzg1MjI0LTc3Zjc1YWFmLTAxOGEtNDQwNi1hMzhhLTI5NzU1ZWI5M2ViNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNzUzMDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MzdjNTVjNDM1ZTQ0OGI3NmU3NGViN2QyNjdlZTU1YTViNDMyNWUyZDM5ZGVkZTMwNmQwYWNjNWM1YTdlMGQzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.apnr6-7cpBggSpiFbed18060JW7BB08fGuXwj4nFezY)
Without inlay hints:
![image](https://private-user-images.githubusercontent.com/100439259/329385297-ffaec271-0639-4573-9037-ca79a1815249.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2OTI2ODQsIm5iZiI6MTczOTY5MjM4NCwicGF0aCI6Ii8xMDA0MzkyNTkvMzI5Mzg1Mjk3LWZmYWVjMjcxLTA2MzktNDU3My05MDM3LWNhNzlhMTgxNTI0OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwNzUzMDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNmRiMDU1NjBkMWIzNmU3MzRhZTFhZTA2M2RjNzE0MTA2MzllZGMzYjE3MGU2N2E0ZDcyZjAxMTQyNmQxYzRhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.pufgdL7vYdPLoXzGP_Vz4vXzGkiIqJ_M9ZkfekLvV1U)
This UI and behavior is now consistent with other languages that support inlay hints in VS such as typescript.