[QuickAccent]Fix unstable language loading #36721
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When opening the list of language selection of Quick Accent on Settings, the first load selects all the languages one by one, triggering a save everytime, meaning the saved state might get into a state where some of the languages are missing.
This PR guards against triggering the "selctionChanged" event if all we're doing is the first load.
It also adds a check against loading a non existing language and adding a null entry to the loaded array after LINQ.
PR Checklist
Validation Steps Performed
Selected many languages and opened QuickAccent's settings.json to verify the language list is well saved. After that, unload the QuickAccent page, load it again and open the selected languages expander. Verify the saved file is still good. Do it many times.