Add "new" labels to navigation #36939
Conversation
|
Why not on dashboard too? Could be placed between label and switch button. |
|
Questions
|
Great callout on the px size, I'll change it to 4 Duration should only be for one release |
| HorizontalAlignment="Center" | ||
| VerticalAlignment="Center" | ||
| FontSize="{ThemeResource InfoBadgeValueFontSize}" | ||
| FontWeight="SemiBold" /> |
There was a problem hiding this comment.
| FontWeight="SemiBold" /> |
There was a problem hiding this comment.
No longer SemiBold, thank you for the feedback ;)
|
@cinnamon-msft |
There was a problem hiding this comment.
I didn't edit this file but I think it started failing the XAML formatting check after I merged main in
| <InfoBadge | ||
| Margin="4,0,0,0" | ||
| Style="{StaticResource NewInfoBadge}" | ||
| Visibility="{x:Bind IsNew, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}" /> |
There was a problem hiding this comment.
BoolToVisibilityConverter is embedded, so may be omitted :) Mode=OneWay may be removed too, this value is not going to change. (default for x:Bind is OneTime)
There was a problem hiding this comment.
I think we should prefer as explicit as possible :) Makes intent easier to read when going through the code if one doesn't know the defaults.
Summary of the Pull Request
Added "New" in the nav to System Tools and ZoomIt now that we have a new utility!
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed