Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Arc-enabled servers - update secure string variable type #2349

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Azure Arc-enabled servers - update secure string variable type #2349

merged 2 commits into from
Jan 10, 2024

Conversation

zaidmohd
Copy link
Contributor

Update the Azure Arc-enabled servers to have the sharedkey param as secure string

@zaidmohd zaidmohd requested a review from lanicolas January 10, 2024 03:40
@zaidmohd zaidmohd self-assigned this Jan 10, 2024
github-actions[bot]
github-actions bot reviewed Jan 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi friend! Thanks you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better.

@zaidmohd zaidmohd added the arc_servers Azure Arc-enabled servers related label Jan 10, 2024
@zaidmohd zaidmohd added this to the January 2024 milestone Jan 10, 2024
@zaidmohd zaidmohd linked an issue Jan 10, 2024 that may be closed by this pull request
Azure Arc-enabled servers - update secure string variable type #2348
Closed
lanicolas
lanicolas approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@lanicolas lanicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@likamrat likamrat merged commit c24436c into microsoft:main Jan 10, 2024
1 check passed
@likamrat likamrat linked an issue Jan 10, 2024 that may be closed by this pull request
Passing of sensitive parameters #2205
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@likamrat likamrat likamrat approved these changes

@lanicolas lanicolas lanicolas approved these changes

Assignees

@zaidmohd zaidmohd

Labels
arc_servers Azure Arc-enabled servers related
Projects
Azure Arc Jumpstart
Status: Done
Milestone
January 2024
Development

Successfully merging this pull request may close these issues.

Azure Arc-enabled servers - update secure string variable type Passing of sensitive parameters
3 participants
@zaidmohd @likamrat @lanicolas