Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arcbox 3.0 - Remove storage SAS token #2630

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Arcbox 3.0 - Remove storage SAS token #2630

merged 6 commits into from
Jul 30, 2024

Conversation

zaidmohd
Copy link
Contributor

  • Remove storage sas token
  • Add managed identity auth for storage
  • Add storage blob data contributor role for the VM MSI

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Hi zaidmohd! Thank you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better.

sebassem
sebassem approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebassem sebassem merged commit f77422e into microsoft:arcbox_3.0 Jul 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebassem sebassem sebassem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaidmohd @sebassem