Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcBox 3.0 - Credential updates and PowerShell Remoting for Linux #2642

Merged
merged 13 commits into from
Aug 3, 2024

Conversation

janegilring
Copy link
Contributor

This pull request includes several updates to the azure_jumpstart_arcbox project, focusing on enhancing security, improving script efficiency, and updating configurations. The most important changes include modifications to hard-coded credentials, adjustments to VM handling logic, and updates to module installations.

Credentials:

  • Updated hard-coded credentials for nested VMs to use more updated values in ArcServersLogonScript.ps1. ($nestedWindowsPassword, $nestedLinuxPassword) [1] [2]

VM Handling Logic:

  • Added conditional checks for the namingPrefix to streamline the renaming and rebooting process of nested VMs. (ArcServersLogonScript.ps1) [1] [2]
  • Replaced repetitive VM status checking loops with more efficient Wait-VM commands. (ArcServersLogonScript.ps1) [1] [2]

Configuration Updates:

  • Changed the VHD source folder URL to point to the pre-production environment. (ArcServersLogonScript.ps1)
  • Increased retry count for SQL server extension installation to improve robustness. (ArcServersLogonScript.ps1)
  • Removed unnecessary module from the installation list in Bootstrap.ps1. ($modules)

Script Efficiency:

  • Streamlined the process of copying and executing scripts on nested Linux VMs by using Copy-VMFile and PowerShell Remoting via SSH. (ArcServersLogonScript.ps1) [1] [2]

Miscellaneous:

  • Removed redundant configuration for incoming connections on port 22 from installArcAgentUbuntu.sh.
  • Added #Requires statement for Pester module in Invoke-Test.ps1 to ensure proper module version is used.
  • Disabled local user access on the storage account in mgmtStagingStorage.bicep.

@janegilring janegilring added the ArcBox Jumpstart ArcBox related label Aug 2, 2024
@janegilring janegilring added this to the August 2024 milestone Aug 2, 2024
@janegilring janegilring requested a review from sebassem August 2, 2024 21:55
@janegilring janegilring self-assigned this Aug 2, 2024
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebassem sebassem merged commit 98e194e into microsoft:arcbox_3.0 Aug 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcBox Jumpstart ArcBox related
Projects
Development

Successfully merging this pull request may close these issues.

2 participants