-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArcBox 3.0 - Credential updates and PowerShell Remoting for Linux #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
…gured from ARM-side Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
…r rename Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
sebassem
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
azure_jumpstart_arcbox
project, focusing on enhancing security, improving script efficiency, and updating configurations. The most important changes include modifications to hard-coded credentials, adjustments to VM handling logic, and updates to module installations.Credentials:
ArcServersLogonScript.ps1
. ($nestedWindowsPassword
,$nestedLinuxPassword
) [1] [2]VM Handling Logic:
namingPrefix
to streamline the renaming and rebooting process of nested VMs. (ArcServersLogonScript.ps1
) [1] [2]Wait-VM
commands. (ArcServersLogonScript.ps1
) [1] [2]Configuration Updates:
ArcServersLogonScript.ps1
)ArcServersLogonScript.ps1
)Bootstrap.ps1
. ($modules
)Script Efficiency:
Copy-VMFile
and PowerShell Remoting via SSH. (ArcServersLogonScript.ps1
) [1] [2]Miscellaneous:
installArcAgentUbuntu.sh
.#Requires
statement for Pester module inInvoke-Test.ps1
to ensure proper module version is used.mgmtStagingStorage.bicep
.