Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made PackageBuild.yml accept arbitrary input sources. #11795

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Jan 6, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Updating the PackageBuild.yml template to be agnostic about the source of the input tarballs. This way the callers have the freedom to store them as they see fit.

Does this affect the toolchain?

No.

Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner January 6, 2025 18:44
@PawelWMS PawelWMS changed the title Pawelwi/templates update fasttrack Made PackageBuild.yml accept arbitrary input sources. Jan 6, 2025
@PawelWMS PawelWMS merged commit fae72dc into fasttrack/3.0 Jan 8, 2025
24 checks passed
@PawelWMS PawelWMS deleted the pawelwi/templates_update_fasttrack branch January 8, 2025 01:45
CBL-Mariner-Bot pushed a commit that referenced this pull request Jan 8, 2025
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants