Append PR number to TF Workspace Name when available #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithJRome
force-pushed
the
311-pr-in-workspace-name
branch
from
6d817b2 to
788cc9c
Compare
KeithJRome
force-pushed
the
311-pr-in-workspace-name
branch
from
67bc5ce to
3efffe6
Compare
Shorter ws name since PR ID is long
…e name must begin with a letter, end with a letter or digit, and not contain consecutive hyphens.'
KeithJRome
force-pushed
the
311-pr-in-workspace-name
branch
from
3efffe6 to
b5e30e0
Compare
ianphil
approved these changes
Oct 9, 2019
| @@ -33,7 +33,9 @@ stages: | |||
| - template: ./infrastructure/azure-pipeline-cicd-compose.yml | |||
| parameters: | |||
| environments: | |||
| - 'devint' | |||
| - name: 'devint' | |||
| enablePrIsolation: true | |||
There was a problem hiding this comment.
Should this come from a variable in the var group?
There was a problem hiding this comment.
Good idea. If it's useful to do that, then we should spin off a post-v1 feature request story for it.
| IFS='/' # delimiter | ||
| read -ra PARTS <<< "$BUILD_SOURCEBRANCH" # split the branch into parts | ||
|
|
||
| if [[ "${#PARTS[@]}" == "4" && "${PARTS[0]}" == "refs" && "${PARTS[1]}" == "pull" && "${PARTS[3]}" == "merge" ]]; then |
There was a problem hiding this comment.
Nice check... sed/awk could be used here, but this does the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
Individual PRs will compete for the same resource groups as the master branch deployment. This is a frequent immediate cause for many of the CD failures that we see in the PR checks for otherwise correct code. This problem is expected to become a more serious issue once a custom build agent is in use (with parallel builds).
Issue Number: #311
What is the new behavior?
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information