ISO template users can optionally provide a TF_VAR_resource_ip_whitelist env-var to control the VNET white-list
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2019 16:35
call the new help mod to parse the string into a TF list user can populate "TF_VAR_resource_ip_whitelist" to override the default whitelist
use TF's heredoc syntax to help with readability
|
@nmiodice gave me some ideas. I'll close thiss, then re-open, later today, when I'ver tried his suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
ISO template users must provide whitelist IP/CIDR input via the
infra/templates/az-isolated-service-single-region/terraform.tfvarsfile (and thus check-in a change to that file to account for their specific self-hosted build agents)Resolves Issue Number #341
What is the new behavior?
ISO template users can optionally provide a
TF_VAR_resource_ip_whitelistenvironment variable (via many means, including Az Pipeline Variable Groups) to control the whitelist.Users that do not use the new, optional env var will see the same behavior as before.