Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider app transfer as a valid command #49

Merged

Conversation

valentin-consulting
Copy link
Contributor

App ownership transfer from CLI always shows help, rather than doing action. It seems command is never marked as valid.

@lucen-ms
Copy link
Collaborator

lucen-ms commented Dec 5, 2024

@valentin-consulting have you actually tested the ownership transfer? Does it work correctly please?

@valentin-consulting
Copy link
Contributor Author

@lucen-ms , yes, i tested it.

  • Without this single line, npx code-push-standalone app transfer [app] [email] always shows help.
  • With this line, it prompts for confirmation, checks permission and registers the transfer. Then, I have to switch account to transfer the app back to me => For me, transfer is ok

@lucen-ms lucen-ms merged commit 73e2067 into microsoft:main Dec 19, 2024
3 checks passed
@lucen-ms
Copy link
Collaborator

Thank you @valentin-consulting !

cotovanugabi pushed a commit to cotovanugabi/turneo-codepush that referenced this pull request Jan 3, 2025
App ownership transfer from CLI always shows help, rather than doing
action. It seems command is never marked as valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants