Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dpdk-bindings] Enhancement: forward compatibility for DPDK v23.11 #1500

Merged
merged 4 commits into from
Feb 7, 2025
Merged

[dpdk-bindings] Enhancement: forward compatibility for DPDK v23.11 #1500

merged 4 commits into from
Feb 7, 2025

Conversation

anandbonde
Copy link
Contributor

These changes will be needed when we move up the DPDK version to v23.11 and beyond, so keep them ready now.

@anandbonde
[dpdk-bindings] Enhancement: update intrinsics flags for bindgen and …
5474a2b 
…inline

* Add the -mavx flag to build of the inline translation unit to match
  the flag passed to clang for bindgen.

* Add the rtm and cldemote flags for both bindgen and inline to make
  visible respective intrinsics in the application namespace. This
  allows build.rs to be robust to DPDK that may have intrinsics option
  enabled instead of inline asm.
@anandbonde
[dpdk-bindings] Enhancement: adjust linking to mlx5 devx
31ac14d 
* use DEVX_LIB_PATH environment to locate the mlx5devx import library
  matching that used by DPDK. The environment variable is documented
  here https://doc.dpdk.org/guides-23.11/platform/mlx5.html

* do not /wholearchive mlx5devx, just link to the dll import library
@anandbonde
[dpdk-bindings] Enhancement: always include rte_config.h first
ca0e264 
dpdk expects/requires you to include rte_config.h before any other
header. don't include rte_build_config.h directly instead include
rte_config.h which includes rte_build_config.h.
@anandbonde
[dpdk-bindings] Enhancement: set -std=c11 when invoking toolchains
8d32e52 
starting with dpdk release 23.11 it is a requirement that application
toolchains use a C11 conformant compiler [1].

1. https://doc.dpdk.org/guides/rel_notes/release_23_11.html
@anandbonde anandbonde requested a review from iyzhang February 7, 2025 16:00
@anandbonde anandbonde self-assigned this Feb 7, 2025
This was referenced Feb 7, 2025
Closed
Closed
Closed
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

libos = catnap
commit id = 8d32e52

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::catnap::transport::epoll 13142607 3677 1524 6987309219 100 6987309219 100
ioc::network::libos::push 17600 497 204 7561828 0 7561828 0
ioc::network::libos::pop 15334 467 192 5693345 0 5693345 0
ioc::network::libos::connect 50 146334 61135 2630178 0 2630178 0
demikernel::sgaalloc 11283 131 55 1166826 0 1166826 0
demikernel::sgafree 11536 76 32 862544 0 862544 0
ioc::network::libos::accept 26 14251 5842 430888 0 430888 0
ioc::network::libos::pushto 1179 350 145 396001 0 396001 0
ioc::network::libos::close 18 23845 9825 326165 0 326165 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

libos = catpowder
commit id = 8d32e52

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once 20005969 685 276 12177901514 46 12172900405 85
bgc::inetstack::poll 10002985 1580 635 14234565712 54 2056664198 14
ioc::network::libos::push 16145 3090 1280 46616140 0 46616140 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11064 401 162 5210899 0 5210899 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 5292 2361 926 5085873 0 5083738 0
ioc::network::libos::pushto 764 5155 2071 4104281 0 4104281 0
ioc::network::libos::pop 9029 529 216 3182214 0 3182214 0
bgc::inetstack::tcp::established::background 11075 1670 663 12189005 0 3067442 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11075 544 216 3056632 0 3056632 0
ioc::network::libos::connect 42 41626 17075 1631958 0 1631958 0
demikernel::sgaalloc 6513 234 98 954320 0 954320 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11021 863 333 854033 0 854033 0
demikernel::sgafree 8753 123 50 619157 0 619157 0
bgc::inetstack::tcp::passiveopen::background 42 16883 6761 454771 0 454771 0
ioc::network::libos::close 47 6525 2637 284536 0 284536 0
ioc::network::libos::accept 40 2262 901 52745 0 52745 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 207 236 96 42004 0 42004 0
bgc::inetstack::arp::background 7 2107 846 10898 0 10898 0
bgc::inetstack::icmp::background 1 2759 1104 2866 0 2866 0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

libos = catnip
commit id = 8d32e52

collapsed_stack num_calls cycles_per_call nanoseconds_per_call total_duration percent_total_duration total_duration_exclusive percent_total_duration_exclusive
bgc::inetstack::poll;inetstack::layer4::poll_once;catnip::runtime::receive 6555909 209 84 1354940958 20 1354940958 45
bgc::inetstack::poll;inetstack::layer4::poll_once 6555909 365 147 2327898625 35 968331722 32
bgc::inetstack::poll 3277955 926 373 2969381704 44 641483079 21
ioc::network::libos::push 16145 1228 504 17451524 0 15272066 1
ioc::network::libos::pushto 8434 1310 561 10610872 0 8831845 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch 2755 2960 1168 4705703 0 4694269 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11058 343 139 4548481 0 4547406 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11069 307 125 2854649 0 2852082 0
bgc::inetstack::tcp::established::background 11069 1112 448 10904447 0 2801003 0
ioc::network::libos::pop 9197 414 167 2660419 0 2660419 0
ioc::network::libos::push;catnip::runtime::transmit 8763 350 144 2366269 0 2366269 0
ioc::network::libos::pushto;catnip::runtime::transmit 8434 236 102 1779027 0 1779027 0
ioc::network::libos::connect 42 37641 15698 1429820 0 1372558 0
demikernel::sgaalloc 7140 162 66 763934 0 763934 0
demikernel::sgafree 9202 97 39 725497 0 725497 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11015 340 132 700313 0 689879 0
bgc::inetstack::tcp::passiveopen::background 42 32729 13352 333508 0 282361 0
ioc::network::libos::close 50 5605 2269 261640 0 261640 0
ioc::network::libos::connect;catnip::runtime::transmit 42 6360 2622 57262 0 57262 0
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 21 16521 6743 51147 0 51147 0
ioc::network::libos::accept 37 2386 971 44881 0 44881 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;udp::receive 78 304 130 23476 0 23476 0
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 15 1863 789 15975 0 15975 0
bgc::inetstack::poll;inetstack::layer4::poll_once;inetstack::layer4::receive_batch;catnip::runtime::transmit 23 570 231 11003 0 11003 0
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 21 554 224 10434 0 10434 0
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 14 772 326 7526 0 7526 0
bgc::inetstack::arp::background 2 2490 1005 6721 0 6721 0
bgc::inetstack::icmp::background 1 2596 1046 2708 0 2708 0

@anandbonde anandbonde merged commit 4de64d5 into dev Feb 7, 2025
14 checks passed
@anandbonde anandbonde deleted the ab-dpdk-tyler-patches branch February 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandbonde @iyzhang