-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ArrayObserver to better account for sort and reverse #7062
base: main
Are you sure you want to change the base?
Update the ArrayObserver to better account for sort and reverse #7062
Conversation
…tionality-for-array-observer
…tionality-for-array-observer
…onality-for-array-observer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally LGTM. My only comment is there are several (array as any)
, I wonder if it makes sense to type it since it's also different from the argument type array: any[]
.
We are typing it as any in other areas of this file because we are attaching things to the array outside of the normal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Pull Request
📖 Description
This change updates the
ArrayObserver
to use some array tracking when applyingsort
orreverse
. This will retain state to overcome the problem seen in #6919. No updates are required by developers.🎫 Issues
Closes #6919
✅ Checklist
General
$ npm run change