-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment errors in OpenDataFunctions.kql #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/templates/finops-hub/modules/scripts/IngestionSetup.kql:1253
- The newly introduced ResourceName variable should be covered by tests to ensure its correct behavior.
| extend ResourceName = tostring(tmp_ResourceDetails.ResourceName)
@@ -6,31 +6,9 @@ | |||
with (docstring = 'Return details about the specified ID.', folder = 'OpenData') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My VS code is telling me that it is still 132138 characters. I can't deploy it: Error BCP184: File 'C:\Projects\finops-toolkit\src\templates\finops-hub\modules\scripts\OpenDataFunctions.kql' exceeded maximum size of 131072 characters.
@@ -6,31 +6,9 @@ | |||
with (docstring = 'Return details about the specified ID.', folder = 'OpenData') | |||
resource_type(id: string) { | |||
dynamic({ | |||
"arizeai.observabilityeval/organizations": { "SingularDisplayName": "Azure Native ArizeAi Cloud Service" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you deciding what to keep and what to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love removing values. While I feel there has to be a better solution, I submitted a PR to split the file into multiple files since we know it will grow over time. I don't love it, but it should get us past the current issue. I validated the deployment so it should resolve the current issues. Thanks for digging into this.
Closing in favor of #1269 |
π οΈ Description
This PR fixes deployment caused by
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?