Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS resolver resource type display names #1249

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Jan 15, 2025

πŸ› οΈ Description

Add DNS resolver resource type display names

πŸ“‹ Checklist

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed labels Jan 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Tool: Open data Datasets to normalize and enhance FinOps reports label Jan 15, 2025
Copy link

@thecloudman thecloudman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. The update matches records we have that support adding this resource type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: Open data Datasets to normalize and enhance FinOps reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants