Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1187 - Remove-FinOpsHub PowerShell Command Does Not Accept/Respect "Yes to All #1251

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

arthurclares
Copy link
Collaborator

…Yes to All" #1187

🛠️ Description

  • Added a list of resources to be deleted before prompting for confirmation.
  • Added logging to print the name of each deleted resource for better visibility.
  • Handled "Yes to All" option to delete all resources without further prompts.

Fixes #1187

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin merged commit 89bc390 into dev Jan 31, 2025
2 checks passed
@flanakin flanakin deleted the arclares-ps-removehubs branch January 31, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution Tool: PowerShell PowerShell scripts and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove-FinOpsHub PowerShell Command Does Not Accept/Respect "Yes to All"
9 participants