Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx the New-FinOpsCostExport #1259

Merged
merged 3 commits into from
Jan 31, 2025
Merged

FIx the New-FinOpsCostExport #1259

merged 3 commits into from
Jan 31, 2025

Conversation

arthurclares
Copy link
Collaborator

@arthurclares arthurclares commented Jan 22, 2025

🛠️ Description

fix: Set granularity to Monthly for PriceSheet exports

  • Updated the New-FinOpsCostExport script to dynamically set the granularity property based on the dataset type.
  • All other datasets continue to use Daily granularity as before.

Fixes #1193

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin merged commit 4c9b65c into dev Jan 31, 2025
2 checks passed
@flanakin flanakin deleted the fix-New-FInOpsCostExport branch January 31, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: PowerShell PowerShell scripts and automation
Projects
None yet
7 participants