Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource types dataset #455

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Add resource types dataset #455

merged 7 commits into from
Nov 29, 2023

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

  • Adds a new ResourceTypes.csv and corresponding ResourceTypes.json.
  • Adds a Get-FinOpsResourceType command.
  • Adds icons for all resource types.

Fixes #372

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Yes (required for dev PRs)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin requested a review from aromano2 as a code owner November 28, 2023 10:52
@flanakin flanakin requested a review from a team November 28, 2023 10:52
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Nov 28, 2023
@flanakin flanakin added Tool: PowerShell PowerShell scripts and automation Tool: Open data Datasets to normalize and enhance FinOps reports labels Nov 28, 2023
@flanakin flanakin added this to the 0.1.2 milestone Nov 28, 2023
@flanakin flanakin merged commit 31d754d into dev Nov 29, 2023
1 check passed
@flanakin flanakin deleted the flanakin/dev/data-resourcetypes branch November 29, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: Open data Datasets to normalize and enhance FinOps reports Tool: PowerShell PowerShell scripts and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Open data] Resource type metadata
1 participant