Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PowerShell 7 + handle throttling errors #785

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Jul 2, 2024

πŸ› οΈ Description

  • Require PowerShell 7 to address capatibility issues
  • Retry in Start-FinOpsCostExport when there are throttling errors

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Yes (required for dev PRs)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin added this to the June 2024 milestone Jul 2, 2024
@flanakin flanakin requested a review from arthurclares July 2, 2024 08:55
@flanakin flanakin requested a review from aromano2 as a code owner July 2, 2024 08:55
@flanakin flanakin requested a review from a team July 2, 2024 08:55
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Jul 2, 2024
@flanakin flanakin added the Tool: PowerShell PowerShell scripts and automation label Jul 9, 2024
@flanakin flanakin merged commit e23a286 into dev Jul 11, 2024
2 checks passed
@flanakin flanakin deleted the flanakin/dev/ps-exp-start-throttle branch July 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: PowerShell PowerShell scripts and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants