Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-FinOpsCostExport -DatasetVersion and new dataset types #850

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Jul 26, 2024

πŸ› οΈ Description

Update Get-FinOpsCostExport to add:

  • New dataset types
  • Support for filgering on DatasetVersion

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2024-08 - August milestone Jul 26, 2024
@flanakin flanakin requested a review from aromano2 as a code owner July 26, 2024 01:20
@flanakin flanakin requested a review from a team July 26, 2024 01:20
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Jul 26, 2024
@flanakin flanakin added the Tool: PowerShell PowerShell scripts and automation label Jul 26, 2024
Copy link
Collaborator

@arthurclares arthurclares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS unit tests passed.

@arthurclares arthurclares merged commit aeb3d45 into dev Jul 31, 2024
2 checks passed
@arthurclares arthurclares deleted the flanakin/dev/ps-exp-dsvertype branch July 31, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: PowerShell PowerShell scripts and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants