Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge NavBar feature branch into main #1731

Merged
Merged
Show file tree
Hide file tree
Changes from 174 commits
Commits
Show all changes
230 commits
Select commit Hold shift + click to select a range
8855375
Add basic two-line title view with examples
Jan 26, 2023
a365cab
Add two-line title support to LargeTitleView
Jan 27, 2023
88096f5
Add examples
Jan 27, 2023
667c430
Add leading alignment support to TwoLineTitleView
Jan 27, 2023
a5ad041
TwoLineTitleView: add InteractivePart.all
Jan 28, 2023
37b48f9
Add animatesTextColor option
Jan 28, 2023
308a166
Merge branch 'main' into two-line-navbar-title
Jan 30, 2023
ecc87d8
Fix lint issues
Jan 30, 2023
44c121b
Address whitespace nit
Jan 31, 2023
72aac97
Remove TODO - we actually do need this here still
Jan 31, 2023
765e332
adjust comment
Jan 31, 2023
462947f
Merge branch 'main' into two-line-navbar-title
Jan 31, 2023
b3747e1
Consolidate guard statements
Jan 31, 2023
70ab7df
Be more explicit about bitmasks in TwoLineTitleView.InteractivePart
Jan 31, 2023
5d8196e
Add documentation for TwoLineTitleViewDelegate
Feb 1, 2023
2f454aa
includes -> contains to stay consistent with `OptionSet` protocol
Feb 1, 2023
6dccdcb
One more includes -> contains in a comment
Feb 1, 2023
31df22a
animatesTextColor -> animatesWhenPressed
Feb 1, 2023
b7842f3
Merge branch 'main' into two-line-navbar-title
Feb 2, 2023
199449b
Remove comment about "legacy" setup function since it just seems to a…
Feb 2, 2023
463de96
Merge branch 'main' into two-line-navbar-title
Feb 2, 2023
e204fe7
fix: Force resize when content size category changes
Feb 3, 2023
6233551
Merge branch 'main' into two-line-navbar-title
Feb 4, 2023
32235a1
Feature-related updates to Navigation and TwoLineTitleView to account…
Feb 4, 2023
f6ad731
Add comment regarding use of TwoLineTitleViewDelegate
Feb 4, 2023
bbde0cc
Merge pull request #1527 from amgleitman/two-line-navbar-title
amgleitman Feb 4, 2023
bfeaba7
Add NavigationBarTitleAccessory to UINavigationItem
Feb 8, 2023
028b81b
Show back button in leading-aligned navigation bar
Feb 10, 2023
736b71c
Improve Navigation test page, include child examples
Feb 10, 2023
52f2c63
NavBarTitleAccessory delegate documentation fix
Feb 10, 2023
2797cb7
Merge pull request #1562 from amgleitman/navbar-custom-tap-action
amgleitman Feb 11, 2023
1aef323
Merge branch 'amgleitman/nav-bar' into navbar-leading-back-button
Feb 11, 2023
00d8ebd
Add grandchildren to navigation demo
Feb 13, 2023
dee1a51
Make nav demo tap action visible in standalone app
Feb 13, 2023
fd63b50
Show back button label in leading-aligned nav bar
Feb 13, 2023
b27dd15
Use Fluent's back button when title is centered
Feb 14, 2023
3fe3ed7
nit: Shorter root-level back title
Feb 14, 2023
0ee3ba0
Fix trailing padding for leading/back button
Feb 15, 2023
6ad57b5
Flip back button for RTL languages
Feb 15, 2023
ff968ac
Fix status bar colors not updating in nav bar cell 6 demo
Feb 15, 2023
bb509b0
Reword NavigationBarBackButtonDelegate docs
Feb 15, 2023
fc74d82
Make backButtonItem non-optional
Feb 15, 2023
49f8f0d
Clean up bar button inset logic
Feb 15, 2023
668f6d8
Improve documentation on updateBarButtonItems
Feb 16, 2023
ab7a70e
Avatar and custom leading button are mutually exclusive
Feb 16, 2023
96a523a
Merge pull request #1579 from amgleitman/navbar-leading-back-button
amgleitman Feb 16, 2023
218dae9
Add title image option to TwoLineTitleView
Feb 22, 2023
f301e8a
Empty subtitle forces small title, even when leading
Feb 22, 2023
ffbfe0f
Use Fluent icons in nav demo instead of SF Symbols
Feb 22, 2023
8ff67d3
Use global spacing tokens for other TwoLineTitleView constants
Feb 24, 2023
368c572
Add one more example
Feb 24, 2023
3cb0398
Merge pull request #1604 from amgleitman/navbar-title-image
amgleitman Feb 25, 2023
a2b5703
Merge branch 'main' into amgleitman/nav-bar
Feb 25, 2023
0b03510
Use new icon token value
Feb 25, 2023
89df32b
Merge pull request #1608 from amgleitman/navbar-update-2023-02-24
amgleitman Feb 25, 2023
9657977
Use spacing tokens for bar button padding
Mar 2, 2023
186c95b
Specify TwoLineTitleView label max sizes in terms of tokens
Mar 3, 2023
f4b9a7a
Bug fix: Label's updateFont() should respect adjustsFontForContentSiz…
Mar 3, 2023
4d40a28
Prevent navbar button text from growing too big
Mar 4, 2023
933d802
Remove 26pt title text since we don't shrink large title text anymore
Mar 4, 2023
42d83e8
Use spacing token for LargeTitleView horizontal spacing
Mar 4, 2023
792820c
Allow for resizing when TwoLineTitleView renders with only one line
Mar 8, 2023
6974b54
Add centered image disclosure test case
Mar 8, 2023
1b23e17
fix pill segment colors in nav demo page
Mar 9, 2023
96ce908
fix clipped badge labels on centered navbar title
Mar 9, 2023
48b2694
NavBar demo controller search bar color fixes
Mar 13, 2023
c5c1f4b
Resize navbar button text when content size changes
Mar 13, 2023
dd7698a
Add extra observers for the new stuff we're adding to UINavigationItem
Mar 13, 2023
ddad51a
Let the OS do Dynamic Type scaling when possible
Mar 13, 2023
2bc6625
Add comment explaining BadgeLabelButton content size category constants
Mar 14, 2023
97d6f90
Merge branch 'os-system-dynamic-type' into navbar-appearance-tweaks-p…
Mar 20, 2023
950accf
Merge pull request #1646 from amgleitman/navbar-appearance-tweaks-plu…
amgleitman Mar 20, 2023
b8918e7
Invalidate Label font when content size category changes
Mar 21, 2023
6889f1a
Merge pull request #1658 from amgleitman/navbar-merge-main-2023-03-13
amgleitman Mar 21, 2023
32ef212
Merge branch 'main' into amgleitman/nav-bar
Mar 21, 2023
1973448
Tokenize TwoLineTitleView
Mar 22, 2023
4031769
Add TwoLineTitleView demo page
Mar 22, 2023
c9eeb51
Force layout whenever fonts update
Mar 22, 2023
7f014e7
nit: reorganize new public declarations after open ones
Mar 22, 2023
b228807
Add `willMove(toWindow:)` override
Mar 22, 2023
8091a0d
Add documentation for TwoLineTitleViewTokenSet
Mar 22, 2023
c0569b8
Move miscellaneous constants to token set file
Mar 22, 2023
dff6fbe
Add more examples
Mar 23, 2023
6219f7b
Make override colors more noticeable
Mar 23, 2023
5ca284a
Space out arguments to makeStandardTitleView
Mar 23, 2023
9a990a3
Use token for border width
Mar 23, 2023
86e6af7
tokenSet.registerOnUpdate makes themeDidChange redundant
Mar 23, 2023
14e11b4
Flatten TwoLineTitleViewTokenSet constants
Mar 23, 2023
e80faf3
Reorganize some TwoLineTitleViewTokenSet constants
Mar 23, 2023
d5e335b
Show down arrow example on demo page
Mar 23, 2023
07b8459
Merge pull request #1659 from amgleitman/tokenize-2ltv
amgleitman Mar 23, 2023
e7dbde8
Merge branch 'main' into amgleitman/nav-bar
Mar 24, 2023
aa25e92
Tokenize NavigationBar colors
Mar 24, 2023
e227054
nit: use a proper info logo for info buttons
Mar 24, 2023
33cdac3
Add search bar test case to nav bar child views
Mar 25, 2023
ec831ab
Add BottomSheet to TwoLineTitleViewDemoController
Mar 28, 2023
6ed6d21
Rename LargeTitleView -> AvatarTitleView
Mar 28, 2023
0bdf274
Move NavigationController demo to tokenized section
Mar 28, 2023
c04cd72
Merge branch 'main' into tokenize-navbar
Mar 28, 2023
b121c49
nit: fix documentation for FluentTheme.typography
Mar 29, 2023
4f37ac2
Add tint variations for dark mode
Mar 30, 2023
388c80f
Add method to apply multiple token overrides at once
Mar 30, 2023
406e083
Tokenize AvatarTitleView
Mar 30, 2023
80af0c6
Ensure font token overrides can propagate through in Navigation demo
Mar 30, 2023
24b3400
Merge branch 'main' into amgleitman/nav-bar
Mar 31, 2023
aa9640c
Merge branch 'amgleitman/nav-bar' into tokenize-navbar
Mar 31, 2023
a7a741b
Make FluentTheme argument optional in NavigationBar.backgroundColor
Mar 31, 2023
f4eb7e8
Remove extraneous setTitleColor call
Mar 31, 2023
1ecb31d
LargeTitleView -> AvatarTitleView
Apr 1, 2023
d072c41
Merge pull request #1686 from amgleitman/large-title-view-to-avatar-t…
amgleitman Apr 2, 2023
98803b5
Merge branch 'amgleitman/nav-bar' into tokenize-navbar
Apr 2, 2023
63ac62a
`forStyle:` -> `for style:`, which is more Swift-like
Apr 10, 2023
c0e412a
Make TwoLineTitleView respect child theme overrides
Apr 10, 2023
386dbad
Undeprecate navigationBarBackgroundColor
Apr 10, 2023
9665178
Merge pull request #1696 from amgleitman/fix-2ltv-overrides
amgleitman Apr 10, 2023
51cc72e
Merge branch 'amgleitman/nav-bar' into tokenize-navbar
Apr 10, 2023
7211069
Use non-nil override values in `ControlTokenSet.setOverrides`
Apr 10, 2023
5620826
Make `setOverrides` internal
Apr 10, 2023
16aabed
Merge pull request #1684 from amgleitman/tokenize-navbar
amgleitman Apr 10, 2023
bfa7070
Revert "Make TwoLineTitleView respect child theme overrides"
amgleitman Apr 11, 2023
7135de7
Merge pull request #1697 from microsoft/revert-1696-fix-2ltv-overrides
amgleitman Apr 11, 2023
2759e6c
Rework TwoLineTitleView logic so overrides work completely
Apr 14, 2023
df72864
Add `.secondaryOnColor` label variant
Apr 17, 2023
a75fb66
Specify default label styles
Apr 17, 2023
8df4bea
Add Verdana font override
Apr 17, 2023
dd4df7b
Use `setOverrides`
Apr 18, 2023
7d034bd
Merge pull request #1703 from amgleitman/fix-2ltv-overrides-again
amgleitman Apr 18, 2023
a77e183
Change token override colors for navigation demo
Apr 18, 2023
8cb62f5
Merge pull request #1708 from amgleitman/validate-navbar-token-overrides
amgleitman Apr 19, 2023
89d1123
Introduce `NavigationBar.TitleStyle` as an eventual replacement for `…
Apr 19, 2023
33675f0
Fix a typo
Apr 20, 2023
13be840
Add `usesLeadingAlignment` to `NavigationBar.TitleStyle`
Apr 20, 2023
799bee1
`usesAvatarTitleView` -> `usesLeadingTitle`
Apr 20, 2023
f563adf
Deprecate `usesLargeTitle` outright
Apr 20, 2023
4b52eb0
Merge branch 'amgleitman/nav-bar' into navbar-title-style
Apr 20, 2023
e060fd8
Make `AvatarTitleView` respect `navigationItem`'s `titleStyle`
Apr 20, 2023
179e1be
Fix leading w/ subtitle examples on test page
Apr 20, 2023
353a199
Merge pull request #1712 from amgleitman/navbar-title-style
amgleitman Apr 24, 2023
47f724a
Add Navigation.md
Apr 25, 2023
9c0bb1e
Add some documentation comments to UINavigationItem extension
Apr 25, 2023
0c084c0
Add links to Apple documentation
Apr 26, 2023
e88defd
Rewording
Apr 26, 2023
8c9fa35
Use direct links to code pages
Apr 26, 2023
f4461f4
More rewording
Apr 26, 2023
8015f0e
Fix link
Apr 26, 2023
12be832
Merge pull request #1714 from amgleitman/navigation-documentation
amgleitman Apr 26, 2023
87e0317
Refactor NavBar height constants
Apr 27, 2023
ba4b621
Hide system NavBar text when using a leading title
Apr 27, 2023
b7e0f47
Center leading titles in compact nav bar
Apr 27, 2023
c849d9d
Add plain centered title examples
Apr 27, 2023
bde61d2
More test cases
Apr 28, 2023
aae15bd
Reorder centered title examples
Apr 28, 2023
3684f24
Fix some constraint identifier names
Apr 28, 2023
3d4c8c7
Add simple collapsible test case
Apr 28, 2023
ba99c82
Use 44px navigation bar in compact mode and ensure title is centered
Apr 29, 2023
b1cbf16
Use custom navigation bar instead of system's 32px
May 3, 2023
da4a1c1
Make systemWantsCompactNavigationBar private
May 3, 2023
2340921
Remove extra shadow from "real" compact navbar
May 3, 2023
a98e9d9
Always recalculate padding after we get a new nav item
May 3, 2023
abc90e7
Don't show trailing image on non-interactive title lines
May 4, 2023
ec103b3
Reorganize logic
May 4, 2023
18680c4
Merge pull request #1728 from amgleitman/2ltv-double-arrow-fix
amgleitman May 4, 2023
784a2c9
Merge pull request #1727 from amgleitman/navbar-44px-everywhere
amgleitman May 4, 2023
7384dc9
Merge branch 'main' into amgleitman/nav-bar
May 4, 2023
5af0153
Revert #1699
May 4, 2023
2e2e22b
Remove some iOS 15 checks
May 5, 2023
f85784a
Merge branch 'main' into navbar-merge-main-2023-05-04-minus-1699
May 5, 2023
627a84f
Remove extra DrawerController demo
May 5, 2023
2a7e5bb
Remove unneeded comment
May 5, 2023
55900f7
nit: fix spacing
May 5, 2023
e64cd6d
Remove extraneous token set update
May 5, 2023
440ddeb
Fix comments
May 5, 2023
1b6fcd4
nit: comment spacing
May 5, 2023
85d1b50
Refactor tokens
May 5, 2023
cbec927
More comment spacing fixes
May 8, 2023
7fe5b71
Move currentStyle definition
May 8, 2023
9ae7f3b
Remove "Button" from label/image variable names
May 8, 2023
70e304b
Add 12x12 and 16x16 chevrons
May 8, 2023
8ef9732
Use UIStackViews instead of manual layout
May 9, 2023
d6b2a8d
Use different size images for different title accessories
May 9, 2023
08f4fb4
Fix SwiftLint complaint
May 9, 2023
f38cce6
Make 12x12 and 16x16 chevrons change color properly
May 9, 2023
e73ab5a
Ensure image views maintain their aspect ratios
May 9, 2023
630e80d
Remove layoutSubviews override
May 9, 2023
634f52a
Reenable accessibility stuff in initializer
May 9, 2023
8578899
Initial color settings
May 9, 2023
f5764fa
Remove "TwoLineTitleView in UIStackView" hack
May 9, 2023
a26f008
Fix text highlighting
May 10, 2023
c47b77f
Remove old layout code
May 10, 2023
9c517fe
Remove unneeded titleSpacing method
May 10, 2023
3347772
containerStackView -> containingStackView
May 10, 2023
a96661d
TwoLineTitleView can still be a UIView
May 10, 2023
42479dd
Remove 20x20 chevrons
May 10, 2023
9d639ef
These calls are no longer needed thanks to autolayout
May 10, 2023
ea96c43
Remove some unneeded variables
May 10, 2023
d63c26b
Ensure 44x44 minimum
May 10, 2023
1e67580
Consolidate comments
May 10, 2023
06b9c2d
Remove unnecessary variable
May 10, 2023
1e8a82b
Fix SwiftLint complaint
May 10, 2023
0e8e5cf
Define minimumTouchSize in one place
May 10, 2023
d40437f
titleLineStackView -> makeEmptyTitleLineStackView
May 10, 2023
8d34269
Revert "Revert #1699"
May 10, 2023
2b1b1bd
Resolve yet another complaint from SwiftLint
May 10, 2023
5c0d60e
Isolate TextColorStyle to UIColor conversion
May 10, 2023
66c64a4
Add `colorForTheme`
May 10, 2023
511e037
Use black background for `.secondaryOnColor`
May 10, 2023
c3b2720
EasyTapButton.minimumTouchSize doesn't need to be public
May 10, 2023
537bca6
Fix TwoLineTitleView bottom sheets in demo app
May 10, 2023
21ca0da
Edit TwoLineTitleView.resources.xcfilelist
May 10, 2023
bbbb056
Group NSLayoutConstraints together
May 10, 2023
24ee01c
Revert "Group NSLayoutConstraints together"
May 10, 2023
90ccf85
Use a single boolean flag for accessory image size
May 10, 2023
d871873
Another SwiftLint warning
May 10, 2023
344179c
Build container stack views at init time (this saves on binary size)
May 10, 2023
8a9d5e1
Merge branch 'new-2ltv' into decouple-textcolorstyle
May 11, 2023
c8fe464
Add Label init with colorForTheme
May 11, 2023
f14a5e8
Add view hierarchy
May 11, 2023
97691e8
Remove TextColorStyle.secondaryOnColor
May 11, 2023
4873de1
Merge branch 'new-2ltv' into decouple-textcolorstyle
May 11, 2023
02f4ef9
Remove commented out code
May 11, 2023
cb00c99
Move colorForTheme declaration
May 11, 2023
130fd35
Revert "Revert "Group NSLayoutConstraints together""
May 12, 2023
f460f62
Merge pull request #1 from amgleitman/new-2ltv
amgleitman May 12, 2023
155c4ad
Merge pull request #2 from amgleitman/decouple-textcolorstyle
amgleitman May 12, 2023
64ccfdf
Merge branch 'main' into navbar-merge-main-2023-05-04-minus-1699
May 12, 2023
4b9ecf4
Merge branch 'navbar-merge-main-2023-05-04-minus-1699' of https://git…
May 12, 2023
8dce3c9
Add overrides to registerOnUpdate
laminesm May 12, 2023
bab152c
Move navigation-specific 2LTV stuff to Navigation subspec
May 15, 2023
27873e2
Merge branch 'navbar-merge-main-2023-05-04-minus-1699' of https://git…
May 15, 2023
ce42eb2
Merge branch 'main' into navbar-merge-main-2023-05-04-minus-1699
May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/FluentUI.Demo/FluentUI.Demo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
532FE3DC26EA6D8D007539C0 /* ActivityIndicatorDemoController_SwiftUI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 532FE3DA26EA6D8D007539C0 /* ActivityIndicatorDemoController_SwiftUI.swift */; };
5336B17D27F7817300B01E0D /* HUDDemoController_SwiftUI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5336B17B27F7817300B01E0D /* HUDDemoController_SwiftUI.swift */; };
5373D55F2694C3070032A3B4 /* AvatarDemoController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5373D55E2694C3070032A3B4 /* AvatarDemoController.swift */; };
66963D0C29CB792E006F5FA9 /* TwoLineTitleViewDemoController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 66963D0B29CB792E006F5FA9 /* TwoLineTitleViewDemoController.swift */; };
6F453CA528AC536300ED91A4 /* ShadowTokensDemoController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6F453CA428AC536300ED91A4 /* ShadowTokensDemoController.swift */; };
6FC8AD3B28DBAF280010C0F8 /* ReadmeViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6FC8AD3A28DBAF280010C0F8 /* ReadmeViewController.swift */; };
6FEED93B28A6E5520099D178 /* AliasColorTokensDemoController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6FEED93A28A6E5520099D178 /* AliasColorTokensDemoController.swift */; };
Expand Down Expand Up @@ -207,6 +208,7 @@
5373D55E2694C3070032A3B4 /* AvatarDemoController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AvatarDemoController.swift; sourceTree = "<group>"; };
5373F95426F28D3A007F1410 /* IndeterminateProgressBarDemoController_SwiftUI.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = IndeterminateProgressBarDemoController_SwiftUI.swift; sourceTree = "<group>"; };
5373F95626F28D9B007F1410 /* IndeterminateProgressBarDemoController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = IndeterminateProgressBarDemoController.swift; sourceTree = "<group>"; };
66963D0B29CB792E006F5FA9 /* TwoLineTitleViewDemoController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TwoLineTitleViewDemoController.swift; sourceTree = "<group>"; };
6F453CA428AC536300ED91A4 /* ShadowTokensDemoController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShadowTokensDemoController.swift; sourceTree = "<group>"; };
6FC8AD3A28DBAF280010C0F8 /* ReadmeViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReadmeViewController.swift; sourceTree = "<group>"; };
6FEED93A28A6E5520099D178 /* AliasColorTokensDemoController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AliasColorTokensDemoController.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -546,6 +548,7 @@
EC98E2B72992FE6900B9DF91 /* TextFieldObjCDemoController.h */,
EC98E2B52992FE5000B9DF91 /* TextFieldObjCDemoController.m */,
FD7DF06121FB941400857267 /* TooltipDemoController.swift */,
66963D0B29CB792E006F5FA9 /* TwoLineTitleViewDemoController.swift */,
92D5FDFC28AC57650087894B /* TypographyTokensDemoController.swift */,
6FEED93A28A6E5520099D178 /* AliasColorTokensDemoController.swift */,
6F453CA428AC536300ED91A4 /* ShadowTokensDemoController.swift */,
Expand Down Expand Up @@ -797,6 +800,7 @@
5336B17D27F7817300B01E0D /* HUDDemoController_SwiftUI.swift in Sources */,
92561E732718AD090072ED00 /* DemoTableViewController.swift in Sources */,
43488C4A270FB7E800124C71 /* NotificationViewDemoController_SwiftUI.swift in Sources */,
66963D0C29CB792E006F5FA9 /* TwoLineTitleViewDemoController.swift in Sources */,
497DC2DE24185896008D86F8 /* PillButtonBarDemoController.swift in Sources */,
B4EF53C5215C45C400573E8F /* PersonaListViewDemoController.swift in Sources */,
A5DCA75E211E3A92005F4CB7 /* DrawerDemoController.swift in Sources */,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ class ColoredPillBackgroundView: UIView {
func updateBackgroundColor() {
switch style {
case .neutralNavBar:
backgroundColor = NavigationBar.Style.system.backgroundColor(fluentTheme: fluentTheme)
backgroundColor = NavigationBar.backgroundColor(for: .system, theme: fluentTheme)
case .brandNavBar:
backgroundColor = NavigationBar.Style.primary.backgroundColor(fluentTheme: fluentTheme)
backgroundColor = NavigationBar.backgroundColor(for: .primary, theme: fluentTheme)
case .canvas:
backgroundColor = fluentTheme.color(.backgroundCanvas)
}
Expand Down
2 changes: 1 addition & 1 deletion ios/FluentUI.Demo/FluentUI.Demo/DemoController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class DemoController: UIViewController {
style: .plain,
target: self,
action: #selector(showAppearancePopover(_:)))
let readmeButton = UIBarButtonItem(image: UIImage(systemName: "i.circle.fill"),
let readmeButton = UIBarButtonItem(image: UIImage(systemName: "info.circle.fill"),
style: .plain,
target: self,
action: #selector(showReadmePopover))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class DemoTableViewController: UITableViewController {
style: .plain,
target: self,
action: #selector(showAppearancePopover))
let readmeButton = UIBarButtonItem(image: UIImage(systemName: "i.circle.fill"),
let readmeButton = UIBarButtonItem(image: UIImage(systemName: "info.circle.fill"),
style: .plain,
target: self,
action: #selector(showReadmePopover))
Expand Down
5 changes: 3 additions & 2 deletions ios/FluentUI.Demo/FluentUI.Demo/Demos.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ struct Demos {
DemoDescriptor("IndeterminateProgressBar", IndeterminateProgressBarDemoController.self),
DemoDescriptor("Label", LabelDemoController.self),
DemoDescriptor("MultilineCommandBar", MultilineCommandBarDemoController.self),
DemoDescriptor("NavigationController", NavigationControllerDemoController.self),
DemoDescriptor("NotificationView", NotificationViewDemoController.self),
DemoDescriptor("Other cells", OtherCellsDemoController.self),
DemoDescriptor("PersonaButtonCarousel", PersonaButtonCarouselDemoController.self),
Expand All @@ -46,7 +47,8 @@ struct Demos {
DemoDescriptor("TableViewCell", TableViewCellDemoController.self),
DemoDescriptor("TableViewHeaderFooterView", TableViewHeaderFooterViewDemoController.self),
DemoDescriptor("Text Field", TextFieldDemoController.self),
DemoDescriptor("Tooltip", TooltipDemoController.self)
DemoDescriptor("Tooltip", TooltipDemoController.self),
DemoDescriptor("TwoLineTitleView", TwoLineTitleViewDemoController.self)
]

static let fluent2DesignTokens: [DemoDescriptor] = [
Expand All @@ -61,7 +63,6 @@ struct Demos {
DemoDescriptor("BottomCommandingController", BottomCommandingDemoController.self),
DemoDescriptor("Card", CardViewDemoController.self),
DemoDescriptor("DateTimePicker", DateTimePickerDemoController.self),
DemoDescriptor("NavigationController", NavigationControllerDemoController.self),
DemoDescriptor("PeoplePicker", PeoplePickerDemoController.self),
DemoDescriptor("PersonaListView", PersonaListViewDemoController.self),
DemoDescriptor("TableViewCellFileAccessoryView", TableViewCellFileAccessoryViewDemoController.self),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ extension TextColorStyle {
return "Regular"
case .secondary:
return "Secondary"
case .secondaryOnColor:
return "Secondary on Color"
case .white:
return "White"
case .primary:
Expand Down
Loading