Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tooltip XCUITest #1748

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented May 16, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Fixed the failing Tooltip XCUITest. #1731 updated the TwoLineTitleView to use a Label instead of an EasyTapButton for the title. However, the tooltip test was not updated to search for a label instead of a button. This PR updates it accordingly.

Binary change

Total increase: 0 bytes
Total decrease: 0 bytes

File Before After Delta
Total 46,711,784 bytes 46,711,784 bytes 🎉 0 bytes
Full breakdown
File Before After Delta

Verification

Visual Verification

Simulator Screen Recording - iPhone 14 Pro - 2023-05-16 at 10 52 25

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner May 16, 2023 15:03
Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MVP!

@joannaquu joannaquu merged commit 0c8c8b2 into microsoft:main May 16, 2023
@joannaquu joannaquu deleted the joannaqu/fix-tooltip-test branch May 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants