[Stack] Add 'SpaceBetween' horizontal alignment option (#3142) #3143
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
requested changes
Jan 9, 2025
| @@ -87,6 +87,7 @@ private string GetHorizontalAlignment() | |||
| HorizontalAlignment.Right => "end", | |||
| HorizontalAlignment.End => "end", | |||
| HorizontalAlignment.Stretch => "stretch", | |||
| HorizontalAlignment.SpaceBetween => "space-between", | |||
There was a problem hiding this comment.
I don't understand why you update only this HorizontalAlignment enumeration, because the GetVerticalAlignment() and GetVerticalAlignment() methods are used for the 2 orientations.
And only justify-content style can use the space-between value.
protected string? StyleValue => new StyleBuilder(Style)
.AddStyle("align-items", GetHorizontalAlignment(), () => Orientation == Orientation.Vertical)
.AddStyle("justify-content", GetVerticalAlignment(), () => Orientation == Orientation.Vertical)
.AddStyle("justify-content", GetHorizontalAlignment(), () => Orientation == Orientation.Horizontal)
.AddStyle("align-items", GetVerticalAlignment(), () => Orientation == Orientation.Horizontal)So what will be the result for the two orientations when the user will select SpaceBetween ?
There was a problem hiding this comment.
AH!
I've missed that!
Something like that?
private string GetHorizontalAlignment()
{
return HorizontalAlignment switch
{
HorizontalAlignment.Left => "start",
HorizontalAlignment.Start => "start",
HorizontalAlignment.Center => "center",
HorizontalAlignment.Right => "end",
HorizontalAlignment.End => "end",
HorizontalAlignment.Stretch => "stretch",
HorizontalAlignment.SpaceBetween => Orientation == Orientation.Vertical ? "start" : "space-between",
_ => "start",
};
}
There was a problem hiding this comment.
Yes... But it's not finished. If you add this value for HorizontalAlignment, you can also add it for VerticalAlignment.
vnbaaij
changed the title
vnbaaij
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR add the feature (space between in Horizontal Alignment) from #3142
🎫 Issues
Fix #3142
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps