Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack] Add 'SpaceBetween' and 'stretch' to horizontal and vertical alignment options (#3142) #3143

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

f4n0
Copy link
Contributor

@f4n0 f4n0 commented Jan 9, 2025

Pull Request

πŸ“– Description

This PR adds a SpaceBetween value to the HorizontalAlignment and Stretch and SpaceBetween to VerticalAlignment (not shown in image below):

image

🎫 Issues

Fix #3142

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@f4n0 f4n0 requested review from vnbaaij and dvoituron as code owners January 9, 2025 11:54
@vnbaaij vnbaaij changed the title [Stack] Added 'SpaceBetween' horizontal alignment option (#3142) [Stack] Add 'SpaceBetween' horizontal alignment option (#3142) Jan 9, 2025
@dvoituron
Copy link
Collaborator

@f4n0 Thank you very much for these changes. Can you please update the PR description, adding the new Horizontal and Vertical values. To have a correct explanation of the new features in the release notes and documentation.

@f4n0 f4n0 changed the title [Stack] Add 'SpaceBetween' horizontal alignment option (#3142) [Stack] Add 'SpaceBetween' and 'stretch' to horizontal and vertical alignment options (#3142) Jan 10, 2025
@vnbaaij vnbaaij merged commit 590de54 into microsoft:dev Jan 10, 2025
4 checks passed
@vnbaaij vnbaaij added this to the v4.11.1 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add SpaceBetween to FluentStack Horizontal Alignment
3 participants