Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aspire 3364 by adding IKeyCodeListner and handler #1866

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Apr 15, 2024

Fix dotnet/aspire#3364. Add DataGrid header resizing by using the keyboard.

  • + - increase column width by 10px
  • - - decrease column width by 10 px
  • Shift+r reset to original values
    (these should be the same keys as used elsewhere in Aspire Dashboard.

grid-resize-keyboard

@vnbaaij vnbaaij added the a11y Accessibillity label Apr 15, 2024
@vnbaaij vnbaaij added this to the v4.6.2 milestone Apr 15, 2024
@vnbaaij vnbaaij self-assigned this Apr 15, 2024
@vnbaaij vnbaaij requested a review from dvoituron as a code owner April 15, 2024 22:14
Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 questions:

  1. Why this "resize" feature works only for the "Typical usage" data grid and not for other in the Demo page?
  2. It seems strange that when you reduce one column (including the "extra strong" column), all the others retain their current size.
    e.g. I pressed - multiple-times on the "Name of Country" column...
    peek

src/Core/Components/DataGrid/FluentDataGrid.razor.cs Outdated Show resolved Hide resolved
src/Core/Components/DataGrid/FluentDataGrid.razor.cs Outdated Show resolved Hide resolved
@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Apr 16, 2024

  1. This only works for resizable DataGrid's
  2. This is fixed now

@vnbaaij
Copy link
Collaborator Author

vnbaaij commented Apr 16, 2024

Resize bugs fixed:
grid-resize-keyboard 2

@vnbaaij vnbaaij requested a review from dvoituron April 16, 2024 11:48
@vnbaaij vnbaaij enabled auto-merge (squash) April 16, 2024 11:48
@vnbaaij vnbaaij merged commit e27e210 into dev Apr 17, 2024
1 check failed
@vnbaaij vnbaaij deleted the users/vnbaaij/fix-aspire-#33364 branch April 17, 2024 08:08
@vnbaaij vnbaaij modified the milestones: v4.6.2, v4.7.0 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibillity
Projects
None yet
2 participants