-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DialogHeader] Allow dialog title exclusion from tab index #3137
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Quadira" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tabindex=“0"
attribute is present to avoid displaying the ’Close” tooltip when the dialog box is open. You can see this in your second example.
@NataschaZorgWijnhoven I'm seeing build errors in the pipelines (not finding |
Pull Request
📖 Description
No possibility to exclude the dialog title from the tab index. The FluentDialogHeader provides a default tabindex of 0 which could not be overwritten.
Repro:
Now it is possible to mark to mark the new parameter ExcludeFromTabFocus with "true", thus changing this tabindex to -1.
This results in the behaviour of the tab being skipped.
Repro:
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps