Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no-environment configuration #1039

Merged
merged 5 commits into from
Jan 23, 2025
Merged

fix no-environment configuration #1039

merged 5 commits into from
Jan 23, 2025

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jan 23, 2025

  • fix ollama/lmstudio lookup

  • Converted listModels and pullModel functions to use TypeScript functions with specific type signatures (ListModelsFunction and PullModelFunction). 🔄
  • Updated function handling to return ok: boolean, status, and error objects. This allows for more robust error handling and status reporting. 💥
  • Added error logging within each function to provide better insight into issues that may occur during model listing or pulling. 📈
  • Ensured all returned objects satisfy the LanguageModelInfo interface, maintaining consistency with the schema expected by the calling functions. 🔗

AI-generated content by pr-describe may be incorrect

Copy link

LGTM 🚀

The changes in GIT_DIFF look good. The functions listModels now return an object with ok, status, and error properties instead of just the models array when there's an error. This makes the function more robust and easier to handle errors in the calling code.

Additionally, the TypeScript types are being used properly throughout the changes, and the code looks clean and consistent. Well done!

AI-generated content by pr-review may be incorrect

@pelikhan pelikhan merged commit 2056636 into main Jan 23, 2025
12 of 13 checks passed
@pelikhan pelikhan deleted the listmodelsfix branch January 23, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant