Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add comprehensive XML support with structured Markdown conversion #307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add comprehensive XML support with structured Markdown conversion #307

wants to merge 1 commit into from
+114 −1

Conversation

ramomen
Copy link

@ramomen ramomen commented Jan 31, 2025

XML Support Enhancement

This PR adds comprehensive XML support to MarkItDown.

Changes

  • Added general XML file support
  • Enhanced RSS/Atom feed handling
  • Improved error messages
  • Updated documentation

Documentation

  • Updated README.md with XML support details
  • Added docstring documentation
  • Included usage examples

Fixes #288

@ramomen
Copy link
Author

ramomen commented Jan 31, 2025

@ramomen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@afourney afourney requested a review from gagb February 9, 2025 04:33
@afourney
Copy link
Member

afourney commented Feb 9, 2025

Looks awesome. Can you add some unit tests, and fix the formatting per the pre-commit hooks?

@afourney afourney added the awaiting op response The PR is awaiting response/edits from the original poster. label Feb 9, 2025
gagb
gagb reviewed Feb 11, 2025
View reviewed changes
src/markitdown/_markitdown.py
)
except Exception as e:
# Provide more detailed error information
error_msg = f"XML dönüştürme hatası: {str(e)}\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is. But if its an error message, can you please ensure its in English.

gagb
gagb reviewed Feb 11, 2025
View reviewed changes
src/markitdown/_markitdown.py
except Exception as e:
# Provide more detailed error information
error_msg = f"XML dönüştürme hatası: {str(e)}\n"
error_msg += "Lütfen dosyanın geçerli bir XML dosyası olduğunu kontrol edin."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

gagb
gagb reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)
Sorry for the delay in reviewing, I have been swamped with other projects.
Can you please add test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagb gagb gagb left review comments

Assignees
No one assigned
Labels
awaiting op response The PR is awaiting response/edits from the original poster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML files not supported
3 participants
@ramomen @afourney @gagb