Skip to content

Commit

Permalink
Relax TLS Unit Test Checks (#4797)
Browse files Browse the repository at this point in the history
  • Loading branch information
nibanks authored Feb 5, 2025
1 parent dea6e3d commit 451c1a8
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/platform/unittest/TlsTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,6 @@ TEST_F(TlsTest, HandshakeParamInfoDefault)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_256, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_384, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand All @@ -920,7 +919,6 @@ TEST_F(TlsTest, HandshakeParamInfoDefault)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_256, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_384, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand Down Expand Up @@ -951,7 +949,6 @@ TEST_F(TlsTest, HandshakeParamInfoAES256GCM)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_256, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_384, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand All @@ -969,7 +966,6 @@ TEST_F(TlsTest, HandshakeParamInfoAES256GCM)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_256, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_384, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand Down Expand Up @@ -1000,7 +996,6 @@ TEST_F(TlsTest, HandshakeParamInfoAES128GCM)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_128, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(128, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_256, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand All @@ -1018,7 +1013,6 @@ TEST_F(TlsTest, HandshakeParamInfoAES128GCM)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_AES_128, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(128, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
//EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_256, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand Down Expand Up @@ -1052,7 +1046,6 @@ TEST_F(TlsTest, HandshakeParamInfoChaCha20)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_CHACHA20, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_256, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand All @@ -1070,7 +1063,6 @@ TEST_F(TlsTest, HandshakeParamInfoChaCha20)
EXPECT_EQ(QUIC_TLS_PROTOCOL_1_3, HandshakeInfo.TlsProtocolVersion);
EXPECT_EQ(QUIC_CIPHER_ALGORITHM_CHACHA20, HandshakeInfo.CipherAlgorithm);
EXPECT_EQ(256, HandshakeInfo.CipherStrength);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeAlgorithm);
EXPECT_EQ(0, HandshakeInfo.KeyExchangeStrength);
EXPECT_EQ(QUIC_HASH_ALGORITHM_SHA_256, HandshakeInfo.Hash);
EXPECT_EQ(0, HandshakeInfo.HashStrength);
Expand Down

0 comments on commit 451c1a8

Please sign in to comment.