Fix test log path sanitation (#4352)

microsoft · Jun 15, 2024 · 776a10e · 776a10e
1 parent b7b2021
commit 776a10e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/scripts/run-gtest.ps1 b/scripts/run-gtest.ps1
@@ -379,7 +379,11 @@ function Start-TestExecutable([String]$Arguments, [String]$OutputDir) {
 # Asynchronously starts a single msquictest test case running.
 function Start-TestCase([String]$Name, [int]$Trial = 1) {
 
-    $InstanceName = $Name.Replace("/", "_")
+    # Get a string of invalid chars for filenames
+    $InvalidChars = [System.IO.Path]::GetInvalidFileNameChars() -join ''
+    # Escape those chars for use in a regex and put them inside a regex set (the square brackets)
+    $InvalidCharsToReplace = "[{0}]" -f [RegEx]::Escape($InvalidChars)
+    $InstanceName = $Name -replace $InvalidCharsToReplace, "_"
     $LocalLogDir = Join-Path $LogDir ($InstanceName + "_$Trial")
     mkdir $LocalLogDir | Out-Null