Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Ubuntu 24.04 GitHub Images #4306

Merged
merged 24 commits into from
Jul 8, 2024
Merged

Test on Ubuntu 24.04 GitHub Images #4306

merged 24 commits into from
Jul 8, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 16, 2024

Description

Just noticed that GitHub has beta support for Ubuntu 24.04. Let's test it out and see how it goes.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner May 16, 2024 11:41
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (28ae555) to head (360547c).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4306      +/-   ##
==========================================
- Coverage   85.76%   84.86%   -0.91%     
==========================================
  Files          56       56              
  Lines       15384    15457      +73     
==========================================
- Hits        13194    13117      -77     
- Misses       2190     2340     +150

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS
Copy link
Contributor

ami-GS commented Jun 4, 2024

PowerShell/PowerShell#21385

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2024
View reviewed changes
@ami-GS ami-GS mentioned this pull request Jun 6, 2024
Merged
@ami-GS
Copy link
Contributor

ami-GS commented Jun 7, 2024

There are build errors in several flavors.

@nibanks
Copy link
Member Author

nibanks commented Jun 10, 2024

Looks like we need to ignore misc-include-cleaner build warnings.

nibanks
nibanks commented Jun 14, 2024
View reviewed changes
src/generated/stdout/quic_trace.c Outdated
@@ -19,9 +19,9 @@
#include <quic_trace.h>


void EncodeHexBuffer(_In_reads_(BufferLen) uint8_t * Buffer,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather ignore this error than make this change. This code was specifically designed for small buffers where size fit in uint8_t.

@ami-GS
Copy link
Contributor

ami-GS commented Jun 15, 2024

-CodeCheck on Ubuntu 24.04 (GCC 13.2.0) shows error below. This cannot be suppressed by add_compile_options(-Wno-misc-header-include-cycle) in src/submodules/CMakeLists.txt or src/generated/CMakeLists.txt

[ 94%] Built target msquic.lttng
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/macros.h:15:10: error: circular header file dependency detected while including 'opensslv.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   15 | #include <openssl/opensslv.h>
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/opensslv.h:109:11: note: 'opensslv' included from here
  109 | # include <openssl/macros.h>
      |           ^
/root/msquic/src/platform/crypt_openssl.c:14:10: note: 'opensslv.h' included from here
   14 | #include "openssl/opensslv.h"
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/srtp.h:25:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   25 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:970:11: note: 'ssl.hs' included from here
  970 | # include <openssl/srtp.h>      /* Support for the use_srtp extension */
      |           ^
/root/msquic/src/platform/crypt_openssl.c:38:10: note: '<U+0006><U+0006><U+0006><U+0006><U+0006>' included from here
   38 | #include "openssl/ssl.h"
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl3.h:23:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   23 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:967:11: note: 'ssl.hr' included from here
  967 | # include <openssl/ssl3.h>
      |           ^
/root/msquic/src/platform/crypt_openssl.c:38:10: note: 'ssl.h' included from here
   38 | #include "openssl/ssl.h"
      |          ^
354 warnings generated.
Suppressed 351 warnings (349 in non-user code, 2 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings treated as errors
gmake[2]: *** [src/platform/CMakeFiles/platform.dir/build.make:286: src/platform/CMakeFiles/platform.dir/crypt_openssl.c.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/srtp.h:25:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   25 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:970:11: note: 'ssl.hs' included from here
  970 | # include <openssl/srtp.h>      /* Support for the use_srtp extension */
      |           ^
/root/msquic/src/platform/selfsign_openssl.c:29:10: note: '<U+0006><U+0006><U+0006><U+0006><U+0006>' included from here
   29 | #include "openssl/ssl.h"
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl3.h:23:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   23 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:967:11: note: 'ssl.hr' included from here
  967 | # include <openssl/ssl3.h>
      |           ^
/root/msquic/src/platform/selfsign_openssl.c:29:10: note: 'ssl.h' included from here
   29 | #include "openssl/ssl.h"
      |          ^
368 warnings generated.
Suppressed 366 warnings (363 in non-user code, 3 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings treated as errors
gmake[2]: *** [src/platform/CMakeFiles/platform.dir/build.make:314: src/platform/CMakeFiles/platform.dir/selfsign_openssl.c.o] Error 1
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/macros.h:15:10: error: circular header file dependency detected while including 'opensslv.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   15 | #include <openssl/opensslv.h>
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/opensslv.h:109:11: note: 'opensslv' included from here
  109 | # include <openssl/macros.h>
      |           ^
/root/msquic/src/platform/tls_openssl.c:14:10: note: 'opensslv.h' included from here
   14 | #include "openssl/opensslv.h"
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/srtp.h:25:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   25 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:970:11: note: 'ssl.hs' included from here
  970 | # include <openssl/srtp.h>      /* Support for the use_srtp extension */
      |           ^
/root/msquic/src/platform/tls_openssl.c:35:10: note: '<U+0006><U+0006><U+0006><U+0006><U+0006>' included from here
   35 | #include "openssl/ssl.h"
      |          ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl3.h:23:11: error: circular header file dependency detected while including 'ssl.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   23 | # include <openssl/ssl.h>
      |           ^
/root/msquic/build/linux/x64_openssl3/_deps/opensslquic-build/openssl3/include/openssl/ssl.h:967:11: note: 'ssl.hr' included from here
  967 | # include <openssl/ssl3.h>
      |           ^
/root/msquic/src/platform/tls_openssl.c:35:10: note: 'ssl.h' included from here
   35 | #include "openssl/ssl.h"
      |          ^
486 warnings generated.
Suppressed 484 warnings (481 in non-user code, 1 NOLINT, 2 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
3 warnings treated as errors
gmake[2]: *** [src/platform/CMakeFiles/platform.dir/build.make:272: src/platform/CMakeFiles/platform.dir/tls_openssl.c.o] Error 1
gmake[2]: Leaving directory '/root/msquic/build/linux/x64_openssl3'
gmake[1]: *** [CMakeFiles/Makefile2:294: src/platform/CMakeFiles/platform.dir/all] Error 2
gmake[1]: Leaving directory '/root/msquic/build/linux/x64_openssl3'
gmake: *** [Makefile:146: all] Error 2

@ami-GS
Copy link
Contributor

ami-GS commented Jul 7, 2024

Remaining is android issue. I have no idea the cause
image

@nibanks
Copy link
Member Author

nibanks commented Jul 7, 2024

Can we just disable Android on 24.04 for now then?

ProjectsByJackHe
ProjectsByJackHe approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ProjectsByJackHe ProjectsByJackHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as tests are passing, and this looks to be mostly pipeline scripting.

@ami-GS ami-GS merged commit 76d3150 into main Jul 8, 2024
474 of 479 checks passed
@ami-GS ami-GS deleted the nibanks/24-04 branch July 8, 2024 22:01
@ami-GS ami-GS mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProjectsByJackHe ProjectsByJackHe ProjectsByJackHe approved these changes

Assignees
No one assigned
Labels
Area: Build Area: Testing Related to test coverage OS: Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nibanks @ami-GS @ProjectsByJackHe