Auto generate rust bindings using rust bindgen #4723
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4723 +/- ##
==========================================
- Coverage 87.07% 85.53% -1.55%
==========================================
Files 56 56
Lines 17378 17378
==========================================
- Hits 15132 14864 -268
- Misses 2246 2514 +268 ☔ View full report in Codecov by Sentry. |
youyuanwu
force-pushed
the
users/youyuanwu/bindgen
branch
from
a279309 to
4124e45
Compare
|
|
||
| #include "msquic.h" | ||
|
|
||
| // bindgen or clang has problem with c marcro functions |
There was a problem hiding this comment.
But this requires people to know to update this file if a new QUIC_STATUS_* is added. Any way to automate validation for that?
There was a problem hiding this comment.
I don't know any way to automate this currently. But this is much better than the current manually written code, where you need to add the new constant for every OS in the lib.rs file.
Even if u automate this, I expect the higher level error handling code still needs to be manually updated.
|
|
||
| /// Read the c header and generate rust bindings. | ||
| #[cfg(feature = "overwrite")] | ||
| fn overwrite_bindgen() { |
There was a problem hiding this comment.
Can we update the GitHub action to ensure the bindings are up to date?
Description
The FFI definitions for rust should be auto generated instead of manually written.
This PR adds a new rust crate with auto generated bindings aiming to replace or remove all the manual bindings in the existing crate. Existing code is not changed. In future, the safe rust wrappers should be written on top of this generated bindings.
supersede #4696 . This PR uses rust bindgen instead of windows bindgen that has better cross platform support.
Generated code is checked in, and an "overwrite" feature can be used to regenerate the code.
MacOs currently uses Linux bindings, we need to generate for MacOs eventually (I don't have a Mac).
Testing
NA. Generated code compiles.
Documentation
NA