[js/web] fix package export for bundlers #23257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 30 out of 45 changed files in this pull request and generated 5 comments.
Files not reviewed (15)
- js/web/test/e2e/exports/testcases/nextjs-default/.gitignore: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/app/globals.css: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/app/page.module.css: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/jsconfig.json: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/package.json: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/components/onnx-helper.js: Evaluated as low risk
- js/web/test/e2e/exports/testcases/nextjs-default/components/onnx-test-bar.js: Evaluated as low risk
- js/web/test/e2e/exports/testcases/nextjs-default/app/page.js: Evaluated as low risk
- js/web/lib/backend-wasm.ts: Evaluated as low risk
- js/web/lib/wasm/wasm-factory.ts: Evaluated as low risk
- js/web/test/e2e/exports/README.md: Evaluated as low risk
- js/web/lib/wasm/proxy-wrapper.ts: Evaluated as low risk
- js/web/script/build.ts: Evaluated as low risk
- js/web/test/e2e/exports/testcases/nextjs-default/app/layout.js: Evaluated as low risk
- js/web/test/e2e/exports/testcases/nextjs-default/next.config.mjs: Evaluated as low risk
Comments suppressed due to low confidence (5)
js/web/test/e2e/exports/testcases/nextjs-default.md:15
- [nitpick] The term 'App Router' should be 'app router' to match the casing used in the rest of the document.
√ Would you like to use App Router? (recommended) ... No
js/web/test/e2e/exports/main.js:30
- Ensure that the ANSI escape codes for colored output are intentional and correctly handled in environments that might not support them.
await runDevTest('vite-default', '\x1b[32m➜\x1b[39m \x1b[1mLocal\x1b[22m:', 5173);
js/web/test/e2e/exports/main.js:31
- Ensure that the ANSI escape codes for colored output are intentional and correctly handled in environments that might not support them.
await runProdTest('vite-default', '\x1b[32m➜\x1b[39m \x1b[1mLocal\x1b[22m:', 4173);
js/web/lib/wasm/wasm-utils-import.ts:1
- The
preloadfunction should have an explicit return type defined for better readability and maintainability.
preload = async (absoluteUrl: string): Promise<string> => {
js/web/lib/wasm/wasm-utils-import.ts:12
- [nitpick] The error handling in the
normalizeUrlfunction should provide more context to help with debugging.
normalizeUrl = (filename: string, prefixOverride?: string) => {
| await page.waitForSelector('#ortstate', { visible: true }); | ||
| // if multi-thread is enabled, check the checkbox | ||
| if (multiThread) { | ||
| await page.locator('#cb-mt').click(); |
There was a problem hiding this comment.
The method 'page.locator' is not valid in Puppeteer. Use 'page.$' or 'page.$eval' instead.
Suggested change
| await page.locator('#cb-mt').click(); | |
| await (await page.$('#cb-mt')).click(); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
The method 'page.locator' is not valid in Puppeteer. Use 'page.$' or 'page.$eval' instead.
Seems like a false statement. page.locator() works well in this test and there is also API reference for the function:
https://pptr.dev/guides/page-interactions#locators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix #22615. (see detailed description in the issue)
A perfect solution would be too difficult to make, because there are a huge number of combinations of usage scenarios, including combinations of development framework, bundler, dev/prod mode, and so on.
This PR is using the following approach:
npm installfor packages built locallynpm run devto start dev server and use puppeteer to launch the browser to testnpm run build && npm run startto test prod build and use puppeteer to launch the browser to testimport.meta.urlto afile://string