slice operator implementation for webgpu native #23264
Open
+349
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
reviewed
Jan 6, 2025
fs-eire
reviewed
Jan 6, 2025
fs-eire
reviewed
Jan 6, 2025
fs-eire
reviewed
Jan 6, 2025
Comment on lines
+743
to
+744
| "^test_center_crop_pad_crop_negative_axes_hwc*", // failed due to new types or shape infer with negative axis for CenterCropPad. | ||
| "^test_center_crop_pad_crop_negative_axes_hwc_expanded*" // failed due to new types or shape infer with negative axis for CenterCropPad. |
There was a problem hiding this comment.
are these 2 lines related to Slice?
There was a problem hiding this comment.
Yes, CenterCropPad is a function op that uses Slice in its definition.
I was seeing the following error in the MacOS CI Pipeline which I believe is because in the failing test the input has 3 dimensions but the cropping shape has 2. There is precedent set by other providers (like under current_failing_tests_OPENVINO_CPU_FP32) to skip this test due to the shape inference discrepancy.
[ONNXRuntimeError] : 1 : FAIL : Non-zero status code returned while running Slice node. Name:'' Status Message: WebGPU validation failed. Error while parsing WGSL: :61:30 error: index 2 out of bounds [0..1]
let steps_2 = uniforms.steps[2];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases operator coverage for webgpu native ep