vmbus_client: track hvsock requests and simplify RPC contract #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-oo
previously approved these changes
Dec 12, 2024
Co-authored-by: Chris Oo <[email protected]>
chris-oo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track hvsock connect requests inside
vmbus_clientso that we can return the response (either an offer or a failure message) to the specific user that made the hvsock request. This is necessary to support multiple concurrent users of vmbus_client.Also, separate connection-related APIs into
VmbusClientAccess, leaving state machine (start/stop/save/restore) inVmbusClient. Ultimately, users of the vmbus client driver will just getVmbusClientAccess(plusOfferInfo(s) for the channels they are using).