Configure NVMe keep-alive ability from host #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-oo
reviewed
Dec 16, 2024
yupavlen-ms
force-pushed
the
reenable_nvme_keepalive
branch
from
d48324b to
22f28de
Compare
chris-oo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform OpenHCL that Host is compatible with NVMe keep-alive feature by adding a new device tree entry
/openhcl/vf-keepalive=nvmewhere vf-keepalive is a list of strings which may be expanded in future to include other device types such as
vf-keepalive=nvme,manaDuring servicing operation the host must now explicitly indicate that NVMe data should be saved (if VM supports it), this change flips the definition of keepalive bit in capabilities_flags bitmask (it used to be an emergency shut-off, not it is an "allow" indication). This flipping resolves compatibility issues with older host OSes after Live Migration.