Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDX: Enable TLB flush hypercall support #511

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

smalis-msft
Copy link
Contributor

@smalis-msft smalis-msft commented Dec 17, 2024

Now that we have the private pool we can finally fully wire this up.

This will not be backported, both because it's only needed for TDX Guest VSM support, and to give us enough time to assess the performance impact.

@smalis-msft smalis-msft requested a review from a team as a code owner December 17, 2024 16:54
@smalis-msft
Copy link
Contributor Author

This works if I turn on the private pool through the command line, but it does not work by default. @chris-oo what's the plan for the private pool going forward? How should I ensure it exists for TDX?

@smalis-msft smalis-msft marked this pull request as draft December 26, 2024 21:19
@chris-oo
Copy link
Member

You'll want to make a change here to modify the bootshim to always create the private pool when tdx with what scaling (in this case, one page per VP).

@smalis-msft
Copy link
Contributor Author

smalis-msft commented Jan 14, 2025

Where is 'here'? What would that look like? Not familiar with where that data comes from.

@chris-oo
Copy link
Member

openhcl_boot/src/host_params/dt.rs

    let vtl2_gpa_pool_size = {

@smalis-msft smalis-msft marked this pull request as ready for review January 17, 2025 19:21
@smalis-msft smalis-msft enabled auto-merge (squash) January 21, 2025 16:29
@smalis-msft smalis-msft merged commit 6d5779b into microsoft:main Jan 21, 2025
25 checks passed
@smalis-msft smalis-msft deleted the tdx-tlb-flush branch January 21, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants