Add much of the basic wiring for TDX Guest VSM support. #541
+517
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mebersol
reviewed
Dec 19, 2024
mebersol
reviewed
Dec 19, 2024
|
otherwise lgtm |
This comment was marked as outdated.
This comment was marked as outdated.
daprilik
reviewed
Dec 26, 2024
smalis-msft
force-pushed
the
tdx-vsm-wiring
branch
from
339f1de to
d466871
Compare
sluck-msft
reviewed
Jan 3, 2025
smalis-msft
force-pushed
the
tdx-vsm-wiring
branch
from
b4a3d63 to
49bea04
Compare
sluck-msft
reviewed
Jan 3, 2025
|
|
||
| let efer = self.vp.backing.efer; | ||
| let efer = self.vp.backing.efer[self.vtl]; | ||
|
|
||
| Ok(Registers { |
There was a problem hiding this comment.
Seems like we need a general scrub of tdx_enter_guest_state? rip, rsp, etc
There was a problem hiding this comment.
Yeah, I'm going to take as a follow-up auditing all the calls to the runner (vp_state, enter_guest_state, etc).
sluck-msft
previously approved these changes
Jan 6, 2025
jstarks
reviewed
Jan 6, 2025
smalis-msft
force-pushed
the
tdx-vsm-wiring
branch
from
bdb8fff to
d288a83
Compare
smalis-msft
force-pushed
the
tdx-vsm-wiring
branch
from
d288a83 to
527ad83
Compare
jstarks
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just most of the inner wiring, replacing hardcoded VTLs with the actual ones. Should introduce no functional changes just yet.