Flowey: Use explicit parameter names instead of auto generated.

[benhillis]

This change moves from auto-generated parameter names to requiring the caller to specify a variable name. This makes for easier to read generated pipeline files and allows for better behavior if another pipeline wants to use queue-time variables to control pipeline behavior.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)

• .github/workflows/openvmm-ci.yaml: Evaluated as low risk
• flowey/flowey_cli/src/pipeline_resolver/direct_run.rs: Evaluated as low risk
• flowey/flowey_cli/src/pipeline_resolver/generic.rs: Evaluated as low risk

Comments suppressed due to low confidence (4)

flowey/flowey_core/src/pipeline.rs:860

• The new behavior of requiring explicit parameter names should be covered by tests to ensure it works as expected.

let param = self.pipeline.new_parameter_bool(name, description, default);

flowey/flowey_core/src/pipeline.rs:877

• The new behavior of requiring explicit parameter names should be covered by tests to ensure it works as expected.

new_parameter_num(name, description, default, possible_values);

flowey/flowey_core/src/pipeline.rs:894

• The new behavior of requiring explicit parameter names should be covered by tests to ensure it works as expected.

new_parameter_string(name, description, default, possible_values);

flowey/flowey_cli/src/pipeline_resolver/github_yaml/mod.rs:368

• Ensure that there are tests covering the new behavior of using explicit parameter names instead of auto-generated ones.

let name = parameters[*pipeline_param_idx].name();